-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mainchain/wallet: add getbalance, listtransactions, sendtransaction rpcs #25
Merged
Ash-L2L
merged 3 commits into
LayerTwo-Labs:master
from
octobocto:2024-11-04-add-get-balance
Nov 6, 2024
Merged
mainchain/wallet: add getbalance, listtransactions, sendtransaction rpcs #25
Ash-L2L
merged 3 commits into
LayerTwo-Labs:master
from
octobocto:2024-11-04-add-get-balance
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octobocto
changed the title
mainchain/wallet: add get balance rpc
WIP: mainchain/wallet: add get balance rpc
Nov 4, 2024
Please don't overwrite all the code you're not changing |
Yes, that's why I marked it as WIP and said a protolint is incoming |
octobocto
force-pushed
the
2024-11-04-add-get-balance
branch
from
November 5, 2024 06:32
b0e82f8
to
f30623b
Compare
octobocto
changed the title
WIP: mainchain/wallet: add get balance rpc
mainchain/wallet: add getbalance, listtransactions, sendtransaction rpcs
Nov 5, 2024
octobocto
force-pushed
the
2024-11-04-add-get-balance
branch
2 times, most recently
from
November 5, 2024 09:51
092cf30
to
9db5607
Compare
Ash-L2L
requested changes
Nov 5, 2024
octobocto
force-pushed
the
2024-11-04-add-get-balance
branch
2 times, most recently
from
November 5, 2024 13:39
559a5a2
to
2a43575
Compare
Ash-L2L
requested changes
Nov 5, 2024
octobocto
force-pushed
the
2024-11-04-add-get-balance
branch
3 times, most recently
from
November 6, 2024 15:04
b073f88
to
2597222
Compare
Ash-L2L
approved these changes
Nov 6, 2024
octobocto
force-pushed
the
2024-11-04-add-get-balance
branch
from
November 6, 2024 19:31
2597222
to
d6ae1be
Compare
Ash-L2L
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GetBalance, ListTransactions and SendTransaction rpcs to the wallet service.