fix(proxy)!: MaxBlobSizeBytes processing
#1762
Merged
+12
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refines blob size validation and limits supported byte units in configuration parsing.
- Refactors the max-blob-size check to use a named
encodedBloblenvariable and corrects the error log to report the post‐encoding length. - Removes support for gigabyte and terabyte units (
gb,gib,tb,tib) inParseBytesAmount, now only allowing KB, MB, MiB.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| api/proxy/store/generated_key/eigenda/eigenda.go | Introduces encodedBloblen and updates the oversized-blob error message |
| api/proxy/common/common.go | Deletes GB/TB unit cases in ParseBytesAmount, defaulting unsupported units |
Comments suppressed due to low confidence (3)
api/proxy/common/common.go:67
- Consider updating this error message to list the supported units (e.g.,
kb,mb,mib) and update any related docs or examples to reflect the removal of GB/TB units.
return 0, fmt.Errorf("unsupported unit: %s", unit)
api/proxy/common/common.go:63
- Add or update unit tests for
ParseBytesAmountto cover the supported units (kb,mb,mib) and ensure it returns errors for removed units likegibortb.
return uint64(num * 1024 * 1024), nil
api/proxy/store/generated_key/eigenda/eigenda.go:116
- [nitpick] Either remove or implement this TODO by relocating the blob length validation into
PutBlobto improve cohesion and reduce duplication.
// TODO: We should move this length check inside PutBlob
ethenotethan
changed the title
MaxBlobSizeBytes processing
litt3
previously approved these changes
Jul 14, 2025
api/proxy/common/common.go
Outdated
| @@ -63,14 +63,6 @@ func ParseBytesAmount(s string) (uint64, error) { | |||
| return uint64(num * 1024 * 1024), nil | |||
| case "mb": | |||
| return uint64(num * 1000 * 1000), nil // Decimal megabyte | |||
There was a problem hiding this comment.
I think we should just remove the base 10 versions of these units... they just don't have a place in our system.
Practically, it would be too easy for someone to use MB and mean binary, but get decimal.
ethenotethan
changed the title
MaxBlobSizeBytes processingMaxBlobSizeBytes processing
ethenotethan
changed the title
MaxBlobSizeBytes processingMaxBlobSizeBytes processing
…an--fix-proxy-max-size-processing
litt3
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks