Updating output code path to correctly detect empty string input for caller-address #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "github.com/urfave/cli/v2" | ||
| ) | ||
|
|
||
| func PopulateCallerAddress( |
There was a problem hiding this comment.
we could technically put this function in a more generic way where allocations commands can also use it. Instead of account address we can just say defaultAddress so we can pass account or operator address.
There was a problem hiding this comment.
we can push that in separate PR. should be fine for now
There was a problem hiding this comment.
Talked offline -- agree and thought about this but opting for easier solution to keep flags specific to their use-cases for now and will address in the CLI refactor workstream.
shrimalmadhur
approved these changes
Dec 19, 2024
bdchatham
merged commit 283790f
into
Layr-Labs:madhur/slashing-allocations
6 checks passed
shrimalmadhur
pushed a commit
that referenced
this pull request
Dec 19, 2024
…caller-address (#274) Co-authored-by: Brandon Chatham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating output code path to correctly detect empty string input for caller-address. Because the input was wrapped in an address object, it defaulted to the 0x0.. address which doesn't match the empty string check enforced.
When the caller address is not provided we want to default to the
account-addressprovided.What Changed?
caller-addressand replaces withaccount-address.