feat: Get and set commands for operatorset split #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdchatham
reviewed
Feb 25, 2025
| @@ -46,14 +46,11 @@ func getGetOperatorSplitFlags() []cli.Flag { | |||
| return baseFlags | |||
| } | |||
|
|
|||
| func GetOperatorSplit(cCtx *cli.Context, isProgrammaticIncentive bool) error { | |||
| func GetOperatorSplit(cCtx *cli.Context, isProgrammaticIncentive bool, isOperatorSet bool) error { | |||
There was a problem hiding this comment.
Usually suggested against passing booleans to alter code branches of a method. Makes methods hard to immediately understand for users. I'd recommend making this an interface and having separate implementations and explicitly implementing only the logic which is different. In this case, you'd have some method getSplit that each interface implements and the generic code will call the implementation given for the specific struct you've created.
| Name: "get-operatorset-split", | ||
| Usage: "Get OperatorSet rewards split", | ||
| Action: func(cCtx *cli.Context) error { | ||
| return GetOperatorSplit(cCtx, true, true) |
There was a problem hiding this comment.
Based on the previous comment about parameters I'd suggest constructing the applicable version of the GetOperatorSplit struct here, then you get the right behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds get and set commands for operatorset split