[accessibility] Set role="button" on the fullscreen control
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malvoz
changed the title
43 tasks
Malvoz
changed the title
role="button" on the fullscreen control
hswong3i
added a commit
to drustack/Leaflet-Leaflet.fullscreen
that referenced
this pull request
Nov 26, 2021
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.
This PR rework icons with Font Awesome SVG:
- Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
`compress-solid.svg`
- Rework styling with SCSS
- Fix accessibility (see Leaflet#110)
- Test with Leaflet v1.7.1
- Update demo with above changes
Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to drustack/Leaflet-Leaflet.fullscreen
that referenced
this pull request
Nov 30, 2021
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.
This PR rework icons with Font Awesome SVG:
- Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
`compress-solid.svg`
- Rework styling with SCSS
- Fix accessibility (see Leaflet#110)
- Test with Leaflet v1.7.1
- Update demo with above changes
Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Member
Author
|
@jfirebaugh Are you able to merge this accessibility improvement? |
runette
pushed a commit
to runette/Leaflet.fullscreen
that referenced
this pull request
May 13, 2022
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.
This PR rework icons with Font Awesome SVG:
- Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
`compress-solid.svg`
- Rework styling with SCSS
- Fix accessibility (see Leaflet#110)
- Test with Leaflet v1.7.1
- Update demo with above changes
Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
role="button"to convey to screen reader users that this is a button and not a link (resolves [accessibility] Fullscreen control should haverole="button"#110).