Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Issue #171: Validate Generated Addresses Against Expected Ones in JS Client Library #184

Closed
wants to merge 25 commits into from
Closed

Address Issue #171: Validate Generated Addresses Against Expected Ones in JS Client Library #184

wants to merge 25 commits into from

Commits on Feb 8, 2023

  1. Add setInputWitnessScript and getInputWitnessScript methods

    José Luis Landabaso Díaz committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    4b7e14e View commit details
    Browse the repository at this point in the history

  2. Fix setInputWitnessScript

    @landabaso
    landabaso committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    5dabd24 View commit details
    Browse the repository at this point in the history

  3. Create a top level package.json file so that this repo can be install… 

    …ed using npm install
    @landabaso
    landabaso committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    6c132e8 View commit details
    Browse the repository at this point in the history

  4. Better run the build script in the child's directory

    @landabaso
    landabaso committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    ad5cc1d View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Merge branch 'LedgerHQ:develop' into develop

    @landabaso
    landabaso authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    b0a66fd View commit details
    Browse the repository at this point in the history

  2. Change amount type from Buffer to number in setInputWitnessUtxo / get… 

    …InputWitnessUtxo
    @landabaso
    landabaso committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    9bd3f4a View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary tiny-secp256k1 dependency

    @landabaso
    landabaso committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7a828fc View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Add support for importing BitcoinJS Psbt for Ledger signing

    @landabaso
    landabaso committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    50d382b View commit details
    Browse the repository at this point in the history

  2. Remove tiny-secp256k1 dependency from package-lock.js

    @landabaso
    landabaso committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    0ca72c4 View commit details
    Browse the repository at this point in the history

  3. Return the 'this' object in fromBitcoinJS to allow chaining

    @landabaso
    landabaso committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5633993 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bitcoinjslib_compat' into develop

    @landabaso
    landabaso committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    05526e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Merge from import-from-bitcoinjs

    @landabaso
    landabaso committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    8ff6495 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Expose DefaultDescriptorTemplate

    @landabaso
    landabaso committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    96c60dd View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Adapt package.json so that this can be published to npm (to be used i… 

    …nternally) without interfering with the original package.json
    @landabaso
    landabaso committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d0f9cd9 View commit details
    Browse the repository at this point in the history

  2. Add proper credit to Ledger for this module

    @landabaso
    landabaso committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    994d959 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Merge remote-tracking branch 'ledgers-remote/develop' into develop

    @landabaso
    landabaso committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    e03c6e1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'ledgers-remote/develop' into develop

    @landabaso
    landabaso committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    079f8aa View commit details
    Browse the repository at this point in the history

  3. Sync wrt ledgers remote

    @landabaso
    landabaso committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    ec45c0d View commit details
    Browse the repository at this point in the history

  4. Remove package-lock.json files (to be in synch with ledger-bitcoin pa… 

    …ckage)
    @landabaso
    landabaso committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    2383790 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Merge branch 'LedgerHQ:develop' into develop

    @landabaso
    landabaso authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8f441a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Address LedgerHQ#171: Compare generated addresses with expected ones

    @landabaso
    landabaso committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    056253f View commit details
    Browse the repository at this point in the history

  2. Addressed review comments: validate addresses at getWalletAddress and… 

    … end of registerWallet; validateAddress replaces validatePolicy; bumped package version; correctly deal with <M;N> format (added a test using this format); Fixed incomplete keys in registerWallet test
    @landabaso
    landabaso committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4192577 View commit details
    Browse the repository at this point in the history

  3. Fix issue with key replacement in address derivation 

    Revised the key replacement logic in the `validateAddress` function to prevent misinterpretation of key indices. The loop now iterates in reverse order to avoid scenarios where, for example, @10 is mistakenly replaced as @1, leaving an extra 0. This change ensures that the correct keys are replaced when deriving the wallet address.
    @landabaso
    landabaso committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    71f8573 View commit details
    Browse the repository at this point in the history

  4. Fix typo and rebase onto develop branch

    @landabaso
    landabaso committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8cf4162 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into improved-validation

    @landabaso
    landabaso authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5bda67b View commit details
    Browse the repository at this point in the history