Replace PR #184: Validate Generated Addresses Against Expected Ones in JS Client Library #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end of registerWallet; validateAddress replaces validatePolicy; bumped package version; correctly deal with <M;N> format (added a test using this format); Fixed incomplete keys in registerWallet test
Revised the key replacement logic in the `validateAddress` function to prevent misinterpretation of key indices. The loop now iterates in reverse order to avoid scenarios where, for example, @10 is mistakenly replaced as @1, leaving an extra 0. This change ensures that the correct keys are replaced when deriving the wallet address.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #189 +/- ##
========================================
Coverage 84.27% 84.27%
========================================
Files 17 17
Lines 2168 2168
========================================
Hits 1827 1827
Misses 341 341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you Salvatore! |
miketlk
added a commit
to miketlk/app-bitcoin-new
that referenced
this pull request
Aug 2, 2024
commit 74190fbbbd831cdf0f5b430471427c5611512775 Merge: e6b45ad 5fe7f05 Author: Salvatore Ingala <[email protected]> Date: Mon May 13 15:51:31 2024 +0200 Merge pull request #259 from LedgerHQ/opreturn Allow up to 5 data pushes in OP_RETURN outputs commit 5fe7f05a063530ce6848fc194627ff712d78305b Author: Salvatore Ingala <[email protected]> Date: Mon May 13 14:17:03 2024 +0200 Tightened standardness checks, added more unit tests; added more comments commit a8759a628d5d48662dfa23da0eb3bbfc033393c3 Author: Salvatore Ingala <[email protected]> Date: Mon May 6 18:41:11 2024 +0200 Update ragger snapshots commit 22358c802fe1de27c16c0a96b4e5e4358c9b6d5d Author: Salvatore Ingala <[email protected]> Date: Mon May 6 17:20:51 2024 +0200 Bump version 2.2.3 and update CHANGELOG commit fe4658eaa5bc025fef33531297a1d424b7ae0328 Author: Salvatore Ingala <[email protected]> Date: Mon May 6 17:08:33 2024 +0200 Add testcases with OP_RETURN with 5 push opcodes (and delete testcase that is now supported) commit 76af9753344765e4e80989184b828ccccb25b96a Author: Salvatore Ingala <[email protected]> Date: Mon May 6 16:22:46 2024 +0200 Allow up to 5 data pushes in OP_RETURN outputs commit e6b45adc71e7d00028e6d51132564493af37fd7e Merge: 5fd382d 69187bf Author: Salvatore Ingala <[email protected]> Date: Mon Apr 8 10:56:16 2024 +0200 Merge pull request #255 from LedgerHQ/release-2.2.2 Prepare release 2.2.2 commit 69187bf44146fc887bcde5bc3da0fd1b6bce0502 Author: Salvatore Ingala <[email protected]> Date: Fri Apr 5 17:14:13 2024 +0200 Update with the changes of the 2.2.2 commit db1e275b959660f51dc157d23720709533d31646 Author: Salvatore Ingala <[email protected]> Date: Mon Apr 8 10:24:56 2024 +0200 Update ragger snapshots commit acdd4fcb0a621f4800d91958ebb4614225ec79e3 Author: Salvatore Ingala <[email protected]> Date: Fri Apr 5 17:13:50 2024 +0200 Bump version to 2.2.2 commit 9946f4604d2fb2bd752948e8b6ab6a0679458c91 Author: Salvatore Ingala <[email protected]> Date: Fri Apr 5 17:18:39 2024 +0200 Update (c) notices commit 5fd382d1da76913a75b7580dd8375ac5499e1b15 Merge: 0a905b1 efe8138 Author: Salvatore Ingala <[email protected]> Date: Mon Apr 8 10:02:48 2024 +0200 Merge pull request #252 from LedgerHQ/improve-ux-wording Improve wording of 'Sign transaction' UX flows. commit efe81389308654bc0dc244bfab3e721dd61b425e Author: Salvatore Ingala <[email protected]> Date: Fri Apr 5 11:53:04 2024 +0200 Update speculos automation for JS library tests commit 4348199b42aabebe1f7e408b33976ffb96d755cd Author: Salvatore Ingala <[email protected]> Date: Fri Apr 5 09:21:48 2024 +0200 Update ragger snapshots commit 822dc3cc990b5692ce0650e2759cfaf7aee539e2 Author: Salvatore Ingala <[email protected]> Date: Fri Apr 5 11:21:39 2024 +0200 Fix some wrong comments in UI code commit c7b2c3f2f0ceca9615500aa05f14bb69594dc69b Author: Salvatore Ingala <[email protected]> Date: Fri Apr 5 09:21:30 2024 +0200 Update tests and ragger instructions for new UX wording commit 27aebbd9fb4fe65ce93c4b6f15ed80ec0da74769 Author: Salvatore Ingala <[email protected]> Date: Fri Apr 5 09:19:59 2024 +0200 Change wording of the transaction signature UX flows - "Approve" after each output becomes "Continue" - The "<eye> Confirm transaction" screen is removed (except for self-transfers) - The final "Accept and send" becomes "Sign transaction" commit 0a905b14e8b88109cf1aaca0e25d6cb2d4f7f055 Merge: 1ddabaf 87eb2f2 Author: Salvatore Ingala <[email protected]> Date: Thu Apr 4 15:16:27 2024 +0200 Merge pull request #250 from LedgerHQ/unspend_xpub Mark unspendable pubkeys as 'dummy' during wallet registration commit 87eb2f2a4c0287c61952c7cb71a9586bf516e76b Author: Salvatore Ingala <[email protected]> Date: Thu Apr 4 11:55:18 2024 +0200 Add venv to .gitignore commit 161bda82adcf42bd1148afb4f67cb68a147158ba Author: Salvatore Ingala <[email protected]> Date: Thu Apr 4 09:23:06 2024 +0200 Add/update ragger snapshots commit 1e778611c306343fcd4aa6025092969af8d0821d Author: Salvatore Ingala <[email protected]> Date: Wed Apr 3 15:57:42 2024 +0200 Add test with unspendable taproot keypath during wallet registration commit 29b166b2ddd2f148752a1b9fe01c40fd46185793 Author: Salvatore Ingala <[email protected]> Date: Wed Apr 3 14:41:00 2024 +0200 Detect unspendable pubkeys during wallet policy registration commit 1ddabaf211b6f196b903430e42ced6dd74d4d400 Merge: 031719b f4d38ed Author: Salvatore Ingala <[email protected]> Date: Wed Apr 3 17:12:12 2024 +0200 Merge pull request #249 from LedgerHQ/missing-return-checks Add return value checks for hash functions from the sdk commit f4d38edfcf4a2da5e55ff9813fe7d61abc6677c8 Author: Salvatore Ingala <[email protected]> Date: Wed Apr 3 16:11:22 2024 +0200 Include return value in LEDGER_ASSERTS failures commit 60a1a72349e1a7b25c12ae30e7a6ebfc33afebff Author: Salvatore Ingala <[email protected]> Date: Wed Mar 27 16:38:15 2024 +0100 Add return value checks for hash functions from the sdk commit 031719b0271fba1bf41b6c5ed9417c90d87f88e6 Merge: 680590c f81498f Author: Sarah Gliner <[email protected]> Date: Wed Apr 3 15:45:05 2024 +0200 Merge pull request #238 from LedgerHQ/ragger-tests Ragger tests commit f81498f371729f036104b041d784dc74fab287e6 Author: Sarah GLINER <[email protected]> Date: Thu Mar 28 15:28:13 2024 +0100 Readme: update for tests commit a364ba5b8a94ba0086f2cf5c70c76ffc3365369c Author: Sarah GLINER <[email protected]> Date: Thu Mar 7 17:49:52 2024 +0100 CI: use reusable workflow for ragger tests commit 64b59a06171deea7ed41951a85c0ed921a3796b2 Author: Sarah GLINER <[email protected]> Date: Wed Mar 6 15:36:26 2024 +0100 tests: add screenshots commit de026877c718310dcd9e7a631ba46c0d03de57d7 Author: Sarah GLINER <[email protected]> Date: Mon Mar 11 15:57:32 2024 +0100 tests: udpdate with ragger client commit c392aa12664b6e53fad818e5ea2f42d6cb556dd6 Author: Sarah GLINER <[email protected]> Date: Thu Jan 25 10:55:40 2024 +0100 gitignore: ignore snapshots-tmp folder commit 3a9b7649e5b8ea800b14e89b875054b5fb537d8f Author: Sarah GLINER <[email protected]> Date: Mon Jul 10 16:59:44 2023 +0200 requirements.txt: add ragger commit 8f9ba77f636662103d5eb34fa0942aa5d5d49d8b Author: Sarah GLINER <[email protected]> Date: Thu Mar 7 10:54:44 2024 +0100 ragger_bitcoin: add ragger client commit d57c9f0719451b9093b29b5efbe507ec311c266c Author: Sarah GLINER <[email protected]> Date: Wed Mar 6 10:42:14 2024 +0100 test_e2e: set change output to have repeatable flows commit fbf5ebd95d4c4f8bd642105126f64aa4b7ab29f5 Author: Sarah GLINER <[email protected]> Date: Thu Feb 29 17:02:35 2024 +0100 sign_psbt: fix typo commit 680590c4d755acc365de9f73b9054d5892311e60 Merge: d32ce5f dd70eba Author: Salvatore Ingala <[email protected]> Date: Wed Mar 27 08:56:40 2024 +0000 Merge pull request #247 from LedgerHQ/bitcoin-test-name Stax: Change homescreen Bitcoin Test to Bitcoin Testnet commit dd70eba899aac6a66d8a38ab4cad7ce4b1d76221 Author: Sarah GLINER <[email protected]> Date: Fri Mar 22 10:40:21 2024 +0100 Stax: Change homescreen Bitcoin Test to Bitcoin Testnet commit d32ce5f0f75cb2966ff9c7e8503da87fdaed82bc Merge: f3dc84a 9ecf4f0 Author: Salvatore Ingala <[email protected]> Date: Wed Mar 20 09:36:31 2024 +0000 Merge pull request #246 from LedgerHQ/sig_deser_fix Fix wrong deserialization of yielded signatures for keypath spends in Rust client commit 9ecf4f076bc27d906dcb1ea577ac14b68cf65a91 Author: Salvatore Ingala <[email protected]> Date: Wed Mar 20 10:08:06 2024 +0100 Bump rust client version to 0.4.1 commit 35e72b0f3b8db6ed15109624e509207adff745cd Author: Salvatore Ingala <[email protected]> Date: Wed Mar 20 09:57:52 2024 +0100 Fix wrong deserialization of yielded signatures for keypath spends commit f3dc84a729bd4442f0f451c40baf7f3e368d48a0 Merge: 2cf708e 6e49bd9 Author: Salvatore Ingala <[email protected]> Date: Tue Mar 19 08:56:45 2024 +0000 Merge pull request #244 from LedgerHQ/merge_master_develop Merge master to develop commit 6e49bd9d6786dc7603ac1c87c7d052353bd54cc5 Merge: 5424897 2cf708e Author: Salvatore Ingala <[email protected]> Date: Tue Mar 19 08:24:11 2024 +0000 Merge branch 'develop' into merge_master_develop commit 54248972b782fbfe45e2fbbc361d2b7407349471 Merge: 0dd6dad 9abd877 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 18 16:57:54 2024 +0000 Merge pull request #243 from LedgerHQ/wrong_tapleaf_hash Fix tapleaf hash computation commit 9abd877d5e325f2e0ea2ef9197bd8e1efb2db6f9 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 18 17:23:25 2024 +0100 Bump version 2.2.1; update CHANGELOG commit 017c1a46750dba6b6642335fe8cd4a042a8e4288 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 18 17:12:46 2024 +0100 Fix key derivation in tapleaf hash computation commit 6489520ff04868c1bfd0262ff531c992dd504065 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 18 17:10:05 2024 +0100 Test for the wrong tapleaf hash computation commit 2cf708eed10207cc2d836a3bdb16a0255138d09f Merge: fbdc1fc fbab288 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 18 09:17:22 2024 +0000 Merge pull request #242 from pgrange/fix_python_client_exemple FIX python exemple commit fbab28876185f6ba298331c666110ce6f6187a3d Author: Pascal Grange <[email protected]> Date: Wed Mar 13 16:47:28 2024 +0100 FIX python exemple `/**` at the end of a key is not allowed in a policy. commit fbdc1fcaaa189ab14382ec57a313b0cc701ed9a2 Merge: 73b3984 5c1141e Author: Salvatore Ingala <[email protected]> Date: Mon Mar 11 15:09:37 2024 +0100 Merge pull request #241 from LedgerHQ/check_pubkey_version Check pubkey version commit 5c1141ea27f118adf45717b902dbfe24119fc5f9 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 11 11:34:12 2024 +0100 Fix outdated docs commit f15ad85b830c1c3847c76b8d67df4296ec71f512 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 11 11:27:12 2024 +0100 Reject xpubs with the wrong BIP32 version during wallet policy registration commit a9ca537501a2f1b9c2242c177e24f22386087b83 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 11 11:25:07 2024 +0100 Add failing test with an external pubkey with the wrong pubkey version commit 73b398465d67b7aa72eadf3ade82f9728ebaf9fa Merge: 205a65a 5bcea87 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 11 10:27:16 2024 +0100 Merge pull request #237 from LedgerHQ/count_keys Refactor `count_distinct_keys_info` commit 5bcea873f6f0bc9d6abe7f7f732d3f1d6f97b575 Author: Salvatore Ingala <[email protected]> Date: Mon Mar 11 10:25:42 2024 +0100 Nit from PR review commit 7585b2a717d6ad9e5800c231365e9685b3d2028f Author: Salvatore Ingala <[email protected]> Date: Mon Feb 26 16:02:13 2024 +0100 Clarify TODO about path restrictions in Makefile commit a9b533dbc1f895e9fb6fecef7f556d9e69106da0 Author: Salvatore Ingala <[email protected]> Date: Mon Feb 26 15:49:40 2024 +0100 Refactor count_distinct_keys_info Adding a call to get_key_placeholder_by_index outside of the loop makes the code a lot more readable, and the extra call is not expensive enough to worry. commit 205a65a67069976efdc158bd94859e9af9f3e5b0 Merge: 4c95b0a 1d46674 Author: Salvatore Ingala <[email protected]> Date: Fri Feb 23 13:11:10 2024 +0100 Merge pull request #231 from LedgerHQ/xch/simplify-cx-calls src: Use new standalone SDK hashing functions commit 1d46674e4caf7b36bebababf877c0482049e1fab Author: Salvatore Ingala <[email protected]> Date: Fri Feb 23 11:14:54 2024 +0100 Lint, and remove unused import commit e9772660eb2928f8fd54e754c54794146f85687f Author: Xavier Chapron <[email protected]> Date: Wed Feb 21 14:58:18 2024 +0100 src: Use new standalone SDK hashing functions commit 4c95b0a55a54d4332433d4dbf9ef81c03475600d Merge: fc8aacf 594ecfb Author: Salvatore Ingala <[email protected]> Date: Thu Feb 22 15:10:47 2024 +0100 Merge pull request #229 from LedgerHQ/sw5515 Handle 0x5515 status word in python client library commit 594ecfbf79536d5ccb236c36239000108f4bb711 Author: Salvatore Ingala <[email protected]> Date: Mon Feb 19 10:29:33 2024 +0100 Fix test on the status words commit 729b07fce2369baf47f457d7aa7b7197d089c862 Author: Salvatore Ingala <[email protected]> Date: Mon Feb 19 10:07:08 2024 +0100 Map both 0x5515 0x6982 to SecurityStatusNotSatisfiedError commit 2e9ea2a204451e334c4af6360aad264c88593f51 Author: Salvatore Ingala <[email protected]> Date: Mon Feb 19 09:41:23 2024 +0100 Fix wrong type annotation commit 11ae481752223265cc07bd937b8f5f9933bd5378 Author: Salvatore Ingala <[email protected]> Date: Mon Feb 19 09:41:03 2024 +0100 Add .venv folders to .gitignore commit fc8aacf41c90df31df780c9a3f51003aecfa7a5e Merge: 1b83e00 f5ce807 Author: Salvatore Ingala <[email protected]> Date: Wed Feb 21 11:57:36 2024 +0100 Merge pull request #226 from LedgerHQ/message-clear-sign Message clear sign commit f5ce80727cdfa10e98df5d048370030cad4f292a Author: Sarah GLINER <[email protected]> Date: Mon Feb 12 12:07:12 2024 +0100 bagl_custom_streaming: decrease_streaming_index instead of reset commit ea93ac686a0869dd8fc1a1321036471aa42199b2 Author: Sarah GLINER <[email protected]> Date: Mon Feb 12 12:07:09 2024 +0100 bagl: trick ui to display arrows for sign_message commit 8c046faf4f1bef616602446fe1bcd3025405a878 Author: Sarah GLINER <[email protected]> Date: Fri Feb 9 12:14:03 2024 +0100 Tests: add test for sign message clear-signing commit c0f18d3ec2a939e771e7423fa40610aded3826ec Author: Sarah GLINER <[email protected]> Date: Wed Feb 7 16:21:45 2024 +0100 sign_message: implement streaming clear-signing for readable messages commit e3f96b8a86dd749bad32b3d37df0f1559c997d74 Author: Sarah GLINER <[email protected]> Date: Fri Feb 9 15:11:51 2024 +0100 bagl_custom_streaming: apply lint commit bd6a86773bb157e287076ecc34fe790ca31b7b8c Author: Sarah GLINER <[email protected]> Date: Wed Feb 7 16:05:21 2024 +0100 bagl: add custom flow for streaming commit 77f5e918ae9b7438bcda214db80677625c6aa54e Author: Sarah GLINER <[email protected]> Date: Tue Jan 9 16:18:08 2024 +0100 clean: remove useless lock check done by the SDK commit 1b83e00f9a260a5d682c274733583ef61d9d6b0f Merge: 34ba07a aa89c63 Author: Salvatore Ingala <[email protected]> Date: Thu Feb 15 10:39:37 2024 +0100 Merge pull request #227 from LedgerHQ/client-address-verification Client address verification in Python library commit aa89c639769edf7f6d384b8dbf2722867f60b03a Author: Salvatore Ingala <[email protected]> Date: Tue Feb 13 10:13:40 2024 +0100 Bump Python client version to 0.3.0 commit 16d7a202ac7f14704352da4920e7a3033c2eb384 Author: Salvatore Ingala <[email protected]> Date: Tue Feb 13 10:08:10 2024 +0100 Delete unused parts of embit commit 826d4c68059d9a2c682564c6ac63046f407c6bb4 Author: Salvatore Ingala <[email protected]> Date: Tue Feb 13 09:46:10 2024 +0100 Add support for "0" and "1" miniscript fragments in local embit clone commit 7144238f25e28c42448dca2fbded153eb00cda74 Author: Salvatore Ingala <[email protected]> Date: Mon Feb 12 16:55:05 2024 +0100 Delete local clone of bip380 commit e9ffc8d2ca6584cfa1f2f656e3d51cad9e428ecf Author: Salvatore Ingala <[email protected]> Date: Mon Feb 12 16:54:07 2024 +0100 Use embit for client-side cross-validation of the generated addresses commit 34ba07a209d69ba10e9cb84dcf7b0bdd7818deca Merge: 0dd6dad 36f8f0b Author: Salvatore Ingala <[email protected]> Date: Wed Feb 7 11:01:07 2024 +0100 Merge pull request #225 from LedgerHQ/appsuffix Add APPVERSION_SUFFIX in Makefile commit 36f8f0b5847f9ff8d9893657452323c77eecc55a Author: Salvatore Ingala <[email protected]> Date: Wed Feb 7 10:52:11 2024 +0100 Add APPVERSION_SUFFIX in Makefile commit 0dd6dadc5d86c850fe3dc9639f37a2d108f884b2 Merge: 4bf0556 a01fe0e Author: Salvatore Ingala <[email protected]> Date: Tue Feb 6 17:39:25 2024 +0100 Merge pull request #224 from LedgerHQ/nanos_missing_pic Missing PIC when accessing nvram commit a01fe0e9c559feb45c867b9d221e85d7bd23aeb9 Author: Salvatore Ingala <[email protected]> Date: Tue Feb 6 17:22:04 2024 +0100 Missing PIC when accessing nvram commit 4bf0556f65f1ffc7232da3260197ca56f5989655 Merge: e5944dd bdcbe1b Author: Salvatore Ingala <[email protected]> Date: Tue Feb 6 09:54:00 2024 +0100 Merge pull request #223 from LedgerHQ/legacy-crash Avoid app crashing on certain malformed PSBTs on legacy inputs commit bdcbe1bfe14e33b950345071a5d06508adf60002 Author: Salvatore Ingala <[email protected]> Date: Mon Feb 5 14:18:51 2024 +0100 Avoid sending a status word twice on failure, which would cause an app crash commit aac2e7a5f4c84398d0dac4df46e4379b5e2f143a Author: Salvatore Ingala <[email protected]> Date: Mon Feb 5 14:09:58 2024 +0100 Make sure that legacy inputs do not have witness-utxo in the psbt commit e5944dd4f49ed71e8672947b623b1145794b9a8a Merge: 59bd68a afc0d34 Author: Salvatore Ingala <[email protected]> Date: Mon Jan 29 14:40:52 2024 +0100 Merge pull request #218 from LedgerHQ/release Prepare release 2.2.0 commit afc0d347dffedbd0cca5913a69b8537c191367de Author: Salvatore Ingala <[email protected]> Date: Mon Jan 22 13:55:56 2024 +0100 Bump version to 2.2.0. Update CHANGELOG commit 59bd68a49a6a21d66aba37b43bf8c1440d549faf Merge: 3fb299d 9d11ff8 Author: Salvatore Ingala <[email protected]> Date: Mon Jan 29 14:21:38 2024 +0100 Merge pull request #221 from LedgerHQ/test_fixes Fix test with 512 inputs commit 9d11ff827b0d4bd39bbccda952af26f346e1b24a Author: Salvatore Ingala <[email protected]> Date: Mon Jan 29 11:38:00 2024 +0100 Make clang static analyzer happy commit fbacb20fa90daeaaaa1cd43840f0281252951755 Author: Salvatore Ingala <[email protected]> Date: Mon Jan 29 11:21:40 2024 +0100 Fix test with 512 inputs (make sure to avoid the high fee warning) commit db5c6d86f62db7f72885dd1d4e7d9ab7ce9b526c Author: Salvatore Ingala <[email protected]> Date: Mon Jan 29 10:55:38 2024 +0100 Fix txmaker incorrectly filling the psbt for taproot transactions commit 3fb299d48c7a7bf9474c067db8556d2adebec397 Merge: 34fe636 323bf42 Author: Salvatore Ingala <[email protected]> Date: Mon Jan 29 14:09:43 2024 +0100 Merge pull request #222 from LedgerHQ/fix-processing Display: Fix processing screen not showing on nano devices commit 323bf42cb9a49ef1f999de125e981bfde679c709 Author: Sarah GLINER <[email protected]> Date: Mon Jan 29 12:16:37 2024 +0100 Display: Fix processing screen not showing on nano devices commit 34fe6369c7f07f304d239a45b58376f6ec9e0fcf Merge: 192391c 805200a Author: Salvatore Ingala <[email protected]> Date: Wed Jan 17 16:55:27 2024 +0100 Merge pull request #217 from edouardparis/client_rs-bitcoin-0.31 Use rust-bitcoin 0.31 and change version for v0.4.0 commit 805200ace316d18f12ccd66aca2bc1a259835015 Author: edouardparis <[email protected]> Date: Wed Jan 17 11:29:23 2024 +0100 ledger_bitcoin_client v0.4.0 commit 8b7c38dec1b6ead6a95a2505a42438ade977cba0 Author: edouardparis <[email protected]> Date: Wed Jan 17 11:28:12 2024 +0100 bump rust-bitcoin 0.31 commit 192391cc1d8d705fd8e52435819ee4668028ceca Merge: d6b3f56 0aec12c Author: Salvatore Ingala <[email protected]> Date: Wed Jan 17 15:20:32 2024 +0100 Merge pull request #216 from LedgerHQ/policy-nvram Save descriptor template to NVRAM during signing on Nano S; general data structure refactoring commit 0aec12c9a2ae3300749c1fd8628e8e9611917a6c Author: Salvatore Ingala <[email protected]> Date: Wed Jan 17 14:53:46 2024 +0100 Nits from code review commit efa7077680880bc4805578a3eb793f36dfb8398a Author: Salvatore Ingala <[email protected]> Date: Thu Dec 14 10:00:18 2023 +0100 Increase the memory limit for descriptor templates; add test for a larger miniscript policy exercising the limit on Nano S commit 3b2422eeb717ed4c9b23f9411f7a6a87beb5c981 Author: Salvatore Ingala <[email protected]> Date: Thu Jan 11 09:51:27 2024 +0100 Add nullness checks when using r_policy_node_scriptlist commit 3e62ba88b3741b26f22bfa980ccd9d66f04dbaa7 Author: Salvatore Ingala <[email protected]> Date: Thu Jan 11 09:42:06 2024 +0100 Removed untyped versions of relative pointers; improved docs, and updated unit tests commit 2631e00c725ee916d5131b2203148d3793e82c48 Author: Salvatore Ingala <[email protected]> Date: Wed Jan 10 19:16:14 2024 +0100 Add null pointer check per clang static analyzer commit 55a905be292d89d55f0985b4d65044c3302f5a44 Author: Salvatore Ingala <[email protected]> Date: Wed Jan 10 18:07:56 2024 +0100 Refactored policy_node_tree_t to use relative pointers commit 8d7357254998732f2fc68769650c6111faa5fb89 Author: Salvatore Ingala <[email protected]> Date: Wed Jan 10 17:06:12 2024 +0100 Generalized and strenghtened relative pointers; refactored policy_node_scriptlist_t to use relative pointers commit 1bd378ab20363e5a4a226548e8d69703808e73f1 Author: Salvatore Ingala <[email protected]> Date: Wed Jan 10 14:27:20 2024 +0100 Refactor: added generic macro to define types and helpers for relative pointers commit c129849ed79a5da2fef77ab0b200aeb6adb9071e Author: Salvatore Ingala <[email protected]> Date: Wed Jan 10 11:38:49 2024 +0100 Use relative pointers for key placeholders in policy; better type for pointers to scripts commit 0a6142ab9e45efa43f8d04197d69370ca30f52b2 Author: Salvatore Ingala <[email protected]> Date: Tue Jan 9 14:08:39 2024 +0100 Move parsed wallet policy into nvram during signing on Nano S, in order to free memory commit d6b3f56bb0957c55a127c250074028d1d4d125c7 Merge: 82c084a 26a0818 Author: Salvatore Ingala <[email protected]> Date: Thu Dec 14 13:28:00 2023 +0100 Merge pull request #215 from LedgerHQ/sdk-updates Updates for newer SDK commit 26a0818524766bbaa07b8f61ceedae80fbf55ac1 Author: Salvatore Ingala <[email protected]> Date: Thu Dec 14 10:41:20 2023 +0100 Mark cx_sha256_update usages as 'never-failing' commit 1d8a0070ef15be04c48705cca9630aa32af650c1 Author: Salvatore Ingala <[email protected]> Date: Thu Dec 14 10:15:20 2023 +0100 Updates for newer SDK commit 82c084a1557817a09ddb243905b835cdc26663ac Merge: 835245e 1bd7607 Author: Salvatore Ingala <[email protected]> Date: Tue Dec 5 13:53:53 2023 +0000 Merge pull request #212 from LedgerHQ/shallowclone Shallow clone in custom image builder commit 1bd76072c4e5488d4feceb965dac8b2e2a63edf8 Author: Salvatore Ingala <[email protected]> Date: Tue Dec 5 14:36:25 2023 +0100 Shallow clone in custom image builder commit 835245ee9dd93f7f8aa6f2bdf16a7002059cb94d Merge: f4271f5 b6a5224 Author: François Beutin <[email protected]> Date: Fri Dec 1 16:57:57 2023 +0100 Merge pull request #211 from LedgerHQ/add/manifest `ledger_app.toml` manifest commit b6a522410408130c8020b6f1a8c73751445a6799 Author: Lucas PASCAL <[email protected]> Date: Fri Dec 1 16:42:30 2023 +0100 [add] ledger_app.toml manifest commit f4271f527b69a48f74f3e8a7e3c2a4b42c0c0ce5 Merge: 207d24a f6d5f85 Author: Sarah Gliner <[email protected]> Date: Wed Nov 15 18:02:28 2023 +0100 Merge pull request #204 from LedgerHQ/spinner-for-stax-swap swap: do not display spinner commit f6d5f85baec7b6223d4392c99f6ffff88f910293 Author: Sarah GLINER <[email protected]> Date: Wed Nov 15 16:50:09 2023 +0100 swap: do not display spinner commit 207d24a725c177c0ff894a31cbe15f12b978743b Merge: 71f7dbe 1a03d51 Author: Sarah Gliner <[email protected]> Date: Mon Nov 13 18:41:54 2023 +0100 Merge pull request #203 from LedgerHQ/swap-improvements Swap improvements commit 1a03d51128fce425c0e1ed231dbfa3310bc280d9 Author: Sarah GLINER <[email protected]> Date: Mon Nov 13 13:51:39 2023 +0100 SwapError: use 0x6B00 for error status commit c25f89316fd108126f1dc6ac48f4955c65832694 Author: Sarah GLINER <[email protected]> Date: Fri Nov 10 18:07:13 2023 +0100 sonarcloud: update workflow commit 0d5bd796190684750e9a7ebe84db9bb0a7eb80d0 Author: Sarah GLINER <[email protected]> Date: Mon Nov 6 18:37:38 2023 +0100 swap: use dedicated error code and exit appropriately commit 71f7dbe2f8a4f62e9502a58e859a4d605f5905b6 Merge: 19d45e6 eaf496b Author: Salvatore Ingala <[email protected]> Date: Fri Nov 10 15:27:59 2023 +0000 Merge pull request #155 from LedgerHQ/tapminiscript Tapminiscript commit eaf496b4c655a70d37867a7d7a21daf042516fbd Author: Salvatore Ingala <[email protected]> Date: Fri Nov 10 13:59:59 2023 +0000 Nits from code review commit 84daf9b1f33840277ce1339ef0d7d6aa6d0e4459 Author: Salvatore Ingala <[email protected]> Date: Mon Nov 6 11:47:57 2023 +0000 Typos and formatting commit a8002f0587f4f64801fb17710631894093c8bf0a Author: Salvatore Ingala <[email protected]> Date: Thu Nov 2 16:38:03 2023 +0100 Increase maximum depth of the supported taptrees on non-NanoS devices; generalize corresponding test so that it adapts to the different limits commit 1015fc317ae2e4323531f231beb2677e1a95bc06 Author: Salvatore Ingala <[email protected]> Date: Tue Jun 27 13:14:43 2023 +0200 Adapt miniscript unit tests to tapscript commit 4cb7dd70e7b1014d0b83ce83042e306a94c04cf5 Author: Salvatore Ingala <[email protected]> Date: Tue Apr 18 11:49:39 2023 +0200 Add set of tests on generated address for miniscripts covering all fragments commit 47e4f5ed9d639429739e685fbb94b6036c57ae47 Author: Salvatore Ingala <[email protected]> Date: Tue Apr 25 17:36:37 2023 +0200 Add tapminiscript tests commit 61077317e9af12e50982fd29ecfaef05bfa55604 Author: Salvatore Ingala <[email protected]> Date: Mon Nov 6 17:06:51 2023 +0000 Check immediately for possible error result of parse_token commit 20bca76d25a49bb8678c833648678de70bca440e Author: Salvatore Ingala <[email protected]> Date: Tue Apr 25 17:25:50 2023 +0200 Support for tapminiscript commit 19d45e6ee0766b3ea849a03b1d112fd10f5681a5 Merge: 3dab7df a8fce7c Author: Salvatore Ingala <[email protected]> Date: Fri Nov 3 16:09:26 2023 +0100 Merge pull request #199 from LedgerHQ/speculos-bitcoin Use image compiled the latest bitcoin-core instead of a custom fork commit a8fce7cdf4fed3c04b8805796df9e58f8cec504a Author: Salvatore Ingala <[email protected]> Date: Thu Nov 2 09:41:22 2023 +0100 Compile bitcoin-core from github instead of using a fixed release commit a743e0c9d55f52bd7d5586ce736863d177167445 Author: Salvatore Ingala <[email protected]> Date: Tue Oct 31 10:32:47 2023 +0100 Reverts 343492d6910deb48a836130a9807a69c1e165723 Now that bitcoin-core has full miniscript support, we no longer need to use a custom branch for e2e tests. commit 3dab7df84f36b12adfd377a1d4a46db5735c981e Merge: e549192 abc4c75 Author: Salvatore Ingala <[email protected]> Date: Tue Oct 31 19:54:14 2023 +0800 Merge pull request #200 from LedgerHQ/fix-ci Fix ci commit abc4c75ba4329a6feabad5148a48d2843d5bc575 Author: Salvatore Ingala <[email protected]> Date: Tue Oct 31 11:57:33 2023 +0100 Delete deprecated function commit 2505266aa7e254ef0c1ffae487c7e28ee6910b66 Author: Salvatore Ingala <[email protected]> Date: Tue Oct 31 10:40:00 2023 +0100 Delete UNUSED() macro from Makefile, as it is defined in the sdk commit e549192a89e3cce0613a7834e17e16f822dcdebd Author: Salvatore Ingala <[email protected]> Date: Thu Oct 19 15:07:28 2023 +0800 Update README.md to mention the Rust client library commit d9f644e7a68121c6db64fdda8482bf1071e30280 Merge: a27fc18 22b6fed Author: Salvatore Ingala <[email protected]> Date: Fri Oct 6 15:19:19 2023 +0200 Merge pull request #196 from LedgerHQ/feewarning Warn if fees are above 10% of total amount commit 22b6fed04f08bbd9bd38b87b94ae20a5bf49a7ba Author: Salvatore Ingala <[email protected]> Date: Fri Oct 6 10:58:27 2023 +0200 Remove other OCR workarounds that are no longer necessary Also reverts 50487ed03b9c78a7b00096df414f3b0355931d28. commit 896f0dc695c843fcec8cf8cb023775ed699a61cf Author: Salvatore Ingala <[email protected]> Date: Fri Oct 6 09:51:49 2023 +0200 Remove broken NanoX OCR workaround in test commit 1e7404b78411f461a923fdcaca9a7226117c0bac Author: Salvatore Ingala <[email protected]> Date: Fri Oct 6 09:30:57 2023 +0200 Nits from code review commit f8d363727f2345bd20cf26ce442166c1a7a6d744 Author: Salvatore Ingala <[email protected]> Date: Fri Sep 22 10:41:46 2023 +0000 Warn if fees are above 10% of total amount commit a27fc18d7887135cb57823d222be93094dde8ef5 Merge: c95993b 56f39db Author: Sarah Gliner <[email protected]> Date: Wed Aug 30 11:27:49 2023 +0200 Merge pull request #194 from LedgerHQ/fix-swap-screen Fix swap screen commit 56f39db8eb9a882cadeafdc2427f9eb028fc762d Author: Sarah GLINER <[email protected]> Date: Mon Aug 28 10:08:50 2023 +0200 ci-workflows: increase timeout commit 16eb6cb88211312491b8f7fc8ae6fd134217d1b6 Author: Sarah GLINER <[email protected]> Date: Wed Aug 23 16:31:45 2023 +0200 tests: fixes for stax commit 3c9779e658482ab5400ed65763c22b245e83f1ff Author: Sarah GLINER <[email protected]> Date: Wed Aug 23 15:29:32 2023 +0200 Tests: temporary fix for broken LNX OCR commit d4c59ed98e885de554d2d8919cd6e7988a861f24 Author: Sarah GLINER <[email protected]> Date: Tue Aug 22 11:42:56 2023 +0200 sign_psbt: do not display in swap mode commit c95993beaf7211d312ce49c7d6ce13259e56e6f8 Merge: b4905a4 e23604e Author: Salvatore Ingala <[email protected]> Date: Thu Aug 10 12:04:31 2023 +0200 Merge pull request #193 from edouardparis/fix-client-rs-example fix ledger_hwi example: no duplicate keys in wallet policy commit e23604e14b90426f72c7cb81a6945ff5cfea1163 Author: edouard <[email protected]> Date: Thu Aug 10 11:42:16 2023 +0200 bitcoin_client_rs v0.3.2 commit d08e38b677d918017cbea24d139afec31b8fc66d Author: edouard <[email protected]> Date: Thu Aug 10 11:30:35 2023 +0200 fix ledger_hwi example: no duplicate keys in wallet policy commit b4905a4b6c1267f630dccb6eb9ae141c9a8c5fae Merge: 39aeae4 487dfeb Author: Salvatore Ingala <[email protected]> Date: Thu Aug 3 09:24:40 2023 +0200 Merge pull request #191 from fametrano/patch-1 do not initialize Decimal from float commit 487dfebceddb62f5ea81156b2d33502e4ae93e77 Author: Ferdinando M. Ametrano <[email protected]> Date: Wed Aug 2 23:21:40 2023 +0200 do not initialize Decimal from float this avoid warnings and prefer explicit proper initialization commit 39aeae41fcc87216085967e056756cfbbe5ceeb1 Merge: 0fd12af 795ce4a Author: Salvatore Ingala <[email protected]> Date: Thu Aug 3 09:15:42 2023 +0200 Merge pull request #190 from LedgerHQ/xch/cleanup-makefile Makefile: Cleanup following recent change in the SDK commit 795ce4a8a328190b88456b9470d90839337b0abb Author: Xavier Chapron <[email protected]> Date: Wed Aug 2 15:52:04 2023 +0200 Makefile: Cleanup following recent change in the SDK commit 0fd12aff1cf4f624a7ba2d9c0723b2dc3e0d5d0a Merge: ab32733 89ab751 Author: Salvatore Ingala <[email protected]> Date: Fri Jul 28 11:21:58 2023 +0200 Merge pull request #189 from bitcoinerlab/new-improved-validation Replace PR #184: Validate Generated Addresses Against Expected Ones in JS Client Library commit 89ab75164584aced526498c011e1d29b16e59f10 Author: José Luis Landabaso Díaz <[email protected]> Date: Wed Jul 26 22:45:38 2023 +0200 Fix typo commit 3e79af496ef2c104d2fdaa535ad695432ecc9c07 Author: José Luis Landabaso Díaz <[email protected]> Date: Thu Jul 20 08:07:55 2023 +0200 Fix issue with key replacement in address derivation Revised the key replacement logic in the `validateAddress` function to prevent misinterpretation of key indices. The loop now iterates in reverse order to avoid scenarios where, for example, @10 is mistakenly replaced as @1, leaving an extra 0. This change ensures that the correct keys are replaced when deriving the wallet address. commit bd527178127c20740392b07c0acda3c68417dd42 Author: José Luis Landabaso Díaz <[email protected]> Date: Thu Jul 20 07:36:45 2023 +0200 Addressed review comments: validate addresses at getWalletAddress and end of registerWallet; validateAddress replaces validatePolicy; bumped package version; correctly deal with <M;N> format (added a test using this format); Fixed incomplete keys in registerWallet test commit 0868aa1b9256dc980e603cab6edbadf2554cce19 Author: José Luis Landabaso Díaz <[email protected]> Date: Mon Jul 17 11:19:46 2023 +0200 Address #171: Compare generated addresses with expected ones commit ab32733d64cfd6ab0d6c25617681c22be0dd5fea Merge: a1fe503 73c385f Author: Salvatore Ingala <[email protected]> Date: Mon Jul 24 17:13:07 2023 +0200 Merge pull request #188 from LedgerHQ/checkkeys Verify that the number of keys in policy being registered is correct commit 73c385fee97c041fffe09f5163c0df5ba79a6866 Author: Salvatore Ingala <[email protected]> Date: Mon Jul 24 15:16:21 2023 +0200 Verify that the number of keys in policy being registered is correct commit a1fe503105658b4b0e0e40e833a623f992f0385d Merge: f56c276 f5f86a2 Author: Salvatore Ingala <[email protected]> Date: Wed Jul 19 15:10:15 2023 +0200 Merge pull request #187 from edouardparis/client_rs-fix-wallet-get_descriptor fix wallet get_descriptor commit f5f86a2ff11db80905a4fcf27655c8050dd834cb Author: edouard <[email protected]> Date: Wed Jul 19 14:59:32 2023 +0200 bitcoin_client_rs: v0.3.1 commit e8d8ca480870adc1c8cb6b691d13b6ad673fdf47 Author: edouard <[email protected]> Date: Wed Jul 19 14:55:43 2023 +0200 fix wallet.get_descriptor: incorrect key path Encountered this bug while registering a policy with multiple keys in a multipath descriptor. commit f56c2767c1dba718a3c14f33e45b9989204f92b9 Merge: b48582a 31f2845 Author: Salvatore Ingala <[email protected]> Date: Wed Jul 19 13:32:39 2023 +0200 Merge pull request #186 from LedgerHQ/update-icon Update icon commit 31f2845543ec5eaa51f3d190e7ac459fd2fb9639 Author: Sarah GLINER <[email protected]> Date: Mon Jul 17 17:43:58 2023 +0200 nbgl: Add safeguard for content height commit 983e3eba22e3dd69d91feb2794ceb69eadd51590 Author: Sarah GLINER <[email protected]> Date: Mon Jul 17 09:44:31 2023 +0200 icons: update with new design for stax commit b48582ae03995dcf96df6c5d7bd2189af408b18a Merge: 238c9ff b152076 Author: Salvatore Ingala <[email protected]> Date: Wed Jul 19 13:31:41 2023 +0200 Merge pull request #185 from LedgerHQ/unserialized_pubkeys Improve pubkey memory management commit b152076662b62faf523529bd8bba7057c218051c Author: Salvatore Ingala <[email protected]> Date: Tue Jul 18 09:56:28 2023 +0200 Add mock for crypto_get_checksum in order to fix wallet.c unit tests commit 12c94a4abcbef60ced49674f7b96e99427907665 Author: Salvatore Ingala <[email protected]> Date: Mon Jul 17 17:23:48 2023 +0200 Verify xpub checksum after decoding commit aa7f6e5235a56372f8957ea856db2cd16cdb4371 Author: Salvatore Ingala <[email protected]> Date: Mon Jul 17 16:46:04 2023 +0200 Represent xpubs in binary rather than base58-serialized commit 238c9ff794ebcefb50841e99a83cc7b6d5c0da55 Merge: f292967 4d71452 Author: Salvatore Ingala <[email protected]> Date: Tue Jul 18 10:30:27 2023 +0200 Merge pull request #183 from edouardparis/bitcoin-0.30 bump bitcoin-0.30 and miniscript-10.0 commit 4d71452ee6d4e6ae064781f0725518a26cecc1d6 Author: edouard <[email protected]> Date: Tue Jul 11 14:58:10 2023 +0200 bitcoin_client_rs: v0.3.0 commit f581abf9d0eaa2d15ac47d9d51ba24baec1cf6b1 Author: edouard <[email protected]> Date: Wed Jul 12 10:05:10 2023 +0200 fix std import in wallet commit e3b502e61cd553e12d961e26c490a8ccebcc1bbf Author: edouard <[email protected]> Date: Mon Jul 10 20:17:46 2023 +0200 bump bitcoin-0.30 and miniscript-10.0 commit f292967c2d4e6a611c08d33c469e915bd12f3f42 Merge: 0cf8c4d da36777 Author: Salvatore Ingala <[email protected]> Date: Thu Jul 13 10:39:38 2023 +0200 Merge pull request #182 from LedgerHQ/standardwallets Improve and refactor logic for standard wallet checking commit da36777af4d286f982409efd2d1e392e7d34efae Merge: 17b84ab 0cf8c4d Author: Salvatore Ingala <[email protected]> Date: Thu Jul 13 10:33:45 2023 +0200 Merge branch 'develop' into standardwallets commit 17b84ab78d07922281f06818bb7dc0c2b65833ca Author: Salvatore Ingala <[email protected]> Date: Mon Jul 10 10:42:49 2023 +0200 Update docs for wallet policies, particularly for taproot scripts commit 8318c44ea9176179957da2d73337d4e6fe81d223 Author: Salvatore Ingala <[email protected]> Date: Fri Jul 7 17:39:30 2023 +0200 Improve and refactor standardness check for wallet policies commit b9595360bd0b1aecd1a1067149fe6be8b0f97cc4 Author: Salvatore Ingala <[email protected]> Date: Thu Jul 6 16:38:33 2023 +0200 Rename 'canonical wallet' to 'default wallet' for consistency with the docs commit 0cf8c4d3ad06c157aef33dbafee06c03573058cb Merge: dbf79fa 203b5d6 Author: Salvatore Ingala <[email protected]> Date: Fri Jul 7 17:47:33 2023 +0200 Merge pull request #181 from kewde/patch-1 fix: repo in package.json commit 2eb138c2fafa2a9e84049f9cb4bb269dcee9c856 Author: Salvatore Ingala <[email protected]> Date: Thu Jul 6 15:58:57 2023 +0200 Add additional tests for non-standard policies in get_wallet_address commit 203b5d67cc67c06dd96c5213694cadd0fd39fc96 Author: Kewde <[email protected]> Date: Fri Jul 7 17:38:25 2023 +0200 fix: repo in package.json commit dbf79fa2a9c9bb25965d6258ed1d509e3ae7eea6 Merge: 1f1a2e5 5801629 Author: Salvatore Ingala <[email protected]> Date: Tue Jul 4 09:25:23 2023 +0200 Merge pull request #179 from LedgerHQ/fbe/add_spinner_at_exchange_start Add a spinner when starting in Exchange mode on Stax commit 58016296852af3512090ed6aecca219bfeeb4f48 Author: Francois Beutin <[email protected]> Date: Mon Jul 3 18:57:28 2023 +0200 Add a spinner when starting in Exchange mode on Stax commit 1f1a2e55dd5d683097e359a916336421a5f53697 Merge: 656087b 07504f4 Author: Salvatore Ingala <[email protected]> Date: Tue Jun 27 14:59:32 2023 +0200 Merge pull request #178 from LedgerHQ/depth-error Always check return value of state_stack_push commit 07504f4eb3df3e8f309cb9136576326c31fafd2c Author: Salvatore Ingala <[email protected]> Date: Tue Jun 27 14:38:14 2023 +0200 Add __attribute__((warn_unused_result)) to most functions in policy.c/policy.h; added an additional missing return value check commit c30d0d7f0ee87511d657339ff524c785f5e64130 Author: Salvatore Ingala <[email protected]> Date: Tue Jun 27 14:07:20 2023 +0200 Always check return value of state_stack_push commit 656087b6418963137d76b6a095c17c3c74ee7a08 Merge: e70166b b2055a5 Author: Salvatore Ingala <[email protected]> Date: Mon Jun 26 15:23:46 2023 +0200 Merge pull request #176 from LedgerHQ/revert-175-revert-170-fbe/return_in_exchange_after_swap Reinstate "Return in Exchange after a valid swap" commit e70166b5493d5e907e2a8b12523c1b4022afdc0a Author: Salvatore Ingala <[email protected]> Date: Mon Jun 26 14:59:39 2023 +0200 Bump version 0.2.2 for both the Python and JS client libraries commit b2055a521c696d64a9b8d55f5fa6a51ef88236e6 Author: Salvatore Ingala <[email protected]> Date: Mon Jun 26 10:26:30 2023 +0200 Revert "Revert "Return in Exchange after a valid swap"" commit f83a4e77fec41827cd2590a648662e4219aead75 Merge: d8f8b1a 36c6911 Author: Salvatore Ingala <[email protected]> Date: Wed Jun 21 14:39:44 2023 +0200 Merge pull request #174 from LedgerHQ/release-2.1.3 Bump version 2.1.3; update CHANGELOG commit 36c6911e997902e575b2975faa87f252165af3ca Merge: c585930 d8f8b1a Author: Salvatore Ingala <[email protected]> Date: Wed Jun 21 14:03:20 2023 +0200 Merge branch 'develop' into release-2.1.3 commit d8f8b1a23db495715b7b4a9d470747faf3c7bb6f Merge: 2338428 695b019 Author: Salvatore Ingala <[email protected]> Date: Wed Jun 21 14:02:17 2023 +0200 Merge pull request #175 from LedgerHQ/revert-170-fbe/return_in_exchange_after_swap Revert "Return in Exchange after a valid swap" commit 695b0194bb823168804d074441d4e253514ef961 Author: Salvatore Ingala <[email protected]> Date: Wed Jun 21 13:54:00 2023 +0200 Revert "Return in Exchange after a valid swap" commit c585930450853d792c2d3e529925418a4fa50f73 Author: Salvatore Ingala <[email protected]> Date: Wed Jun 21 11:55:18 2023 +0200 Bump version 2.1.3; update CHANGELOG commit 233842877b2b3a2b6aae6dc94a1e01bbc26ee627 Merge: 00d55dd ea2e273 Author: Salvatore Ingala <[email protected]> Date: Wed Jun 21 11:39:42 2023 +0200 Merge pull request #173 from LedgerHQ/109-selftransfers Add special wording for self-transfers commit ea2e273154028f349a2613425ea142c72af0d223 Author: Salvatore Ingala <[email protected]> Date: Wed Jun 21 10:03:13 2023 +0200 Avoid code duplication for self-transfers UI commit b22692b7cc2c8d743ea211886bceedb17010344a Author: Salvatore Ingala <[email protected]> Date: Mon Jun 19 13:28:25 2023 +0200 Add special wording for self-transfers commit 00d55ddaad64be655f4c5095afe0c117ebb730b9 Merge: f1d379a 10bd373 Author: Salvatore Ingala <[email protected]> Date: Mon Jun 19 13:30:50 2023 +0200 Merge pull request #172 from LedgerHQ/164-opreturn Allow naked OP_RETURN outputs commit 10bd3732d1837e5bfc3866cefd9d9ad937d54ea2 Author: Salvatore Ingala <[email protected]> Date: Mon Jun 19 10:22:14 2023 +0200 Allow naked OP_RETURN outputs commit f1d379a67bce4a6f0589a4768c9a1359533ced13 Merge: d1c950b 375277b Author: Salvatore Ingala <[email protected]> Date: Mon Jun 19 10:25:36 2023 +0200 Merge pull request #166 from LedgerHQ/client-check-address Compare generated addresses with the expected ones in the client library commit 375277b1a85bbc705b326c75a220d5216991ae40 Author: Salvatore Ingala <[email protected]> Date: Wed Jun 14 10:04:41 2023 +0200 Reject policies with "thresh(1," in the JS client commit 5feaa063ba97cbd26786c1115144a9f2e15a5b86 Author: Salvatore Ingala <[email protected]> Date: Tue Jun 13 16:49:23 2023 +0200 Document paranoid_client feature commit 5b6c1414aeea9d6cc0bd2ae6ccc19723e86e4340 Author: Salvatore Ingala <[email protected]> Date: Tue Jun 13 15:53:04 2023 +0200 Compare addresses with rust-miniscript in the Rust client library commit 601695d828c4fcdbcdf31c0636c601ccbdd7c386 Author: Salvatore Ingala <[email protected]> Date: Mon May 29 14:50:52 2023 +0200 Fix typing issue with bs58check commit 278637ecf34ace8d81cd14aefed53b7dd29c640a Author: Salvatore Ingala <[email protected]> Date: Mon May 29 15:46:23 2023 +0200 Update embit and bip32 in test suites commit dc8fd4ff0ea2a88f6835dfa4ca4f3fed014b53ee Author: Salvatore Ingala <[email protected]> Date: Mon May 29 14:29:41 2023 +0200 Compare generated addresses with the expected ones in the client library commit d1c950bd271b0ba07176548a7ee21cd82c85f3e7 Merge: 7a1b984 356ad47 Author: Salvatore Ingala <[email protected]> Date: Wed Jun 14 10:05:58 2023 +0200 Merge pull request #170 from LedgerHQ/fbe/return_in_exchange_after_swap Return in Exchange after a valid swap commit 356ad4715bd876467a91f879ad403f4ffca37d12 Author: Francois Beutin <[email protected]> Date: Tue Jun 13 15:56:03 2023 +0200 Return the Swap status to Exchange commit dc5abbede15aed38840246cb1865ea30b947f8dd Author: Francois Beutin <[email protected]> Date: Tue Jun 13 15:35:44 2023 +0200 Update Exchange API file commit 7a1b984174816ec4ca04e08dc96f59764cbd74b1 Merge: 68e888a a866e3f Author: Salvatore Ingala <[email protected]> Date: Mon Jun 12 15:10:11 2023 +0200 Merge pull request #169 from fionn/typing Declare type annotations commit a866e3f1a71be7d16d7c2328d4189f693463f953 Author: Fionn Fitzmaurice <[email protected]> Date: Fri Jun 9 19:02:04 2023 +0800 Declare type annotations The Python module is statically typed, but does not export the type information. This adds the py.typed marker as per PEP 561. commit 68e888aaeb5af711fdd606bcc1be2938a1476a98 Merge: 805cc10 34e1d77 Author: Salvatore Ingala <[email protected]> Date: Wed May 31 10:58:00 2023 +0200 Merge pull request #139 from edouardparis/add-tapscript-signature-to-client_rs Add tapscript signature to rust client commit 34e1d77799d350eafc063be499fa7b0e707dbfd6 Author: edouard <[email protected]> Date: Tue May 30 12:37:40 2023 +0200 fix: clippy warnings commit 92d482258bfd2df55011a0b37786c26476007708 Author: edouard <[email protected]> Date: Mon Apr 3 15:36:35 2023 +0200 Add tapscript signature to rust client commit 805cc105ca99c02e465a4384eb0e83839e1a5537 Merge: f50fb73 1894450 Author: Salvatore Ingala <[email protected]> Date: Tue May 30 13:04:06 2023 +0200 Merge pull request #167 from LedgerHQ/xch/crypto-readability Clean Makefile and drop all TRY/CATCH around crypto functions commit f50fb7368bb6281bf0d2c23d605b88fb817dd90e Merge: 8389ff5 2b6b842 Author: Salvatore Ingala <[email protected]> Date: Tue May 30 11:21:48 2023 +0200 Merge pull request #162 from LedgerHQ/fix-thresh Fixes for thresh fragment commit 2b6b8423fb2c125a95093a7daa419670f0541735 Author: Salvatore Ingala <[email protected]> Date: Fri May 26 14:17:06 2023 +0200 Fix comment in and_n specs; fix calculation for 'o' for or_c commit 1894450e433b8bee42718efbf0689e074cee7fed Author: Salvatore Ingala <[email protected]> Date: Tue May 30 10:38:26 2023 +0200 Rewrite functions in crypto.c using throwing functions with their _no_throw equivalent commit d23603fbb301e45bcaa8bc93e84c8f749ee96c4f Author: Xavier Chapron <[email protected]> Date: Mon May 29 17:34:47 2023 +0200 src: crypto.c: Remove the need for TRY/FINALLY block when using crypto_derive_symmetric_key commit 2ca624822e63a2625a9c2977b7fece26b28e0632 Author: Xavier Chapron <[email protected]> Date: Mon May 29 17:22:08 2023 +0200 src: crypto.c: Replace crypto_derive_private_key by equivalent bip32_derive_init_privkey_256 commit 4bc0dcb475ccf2703dd0ef2fcf2a9134dd3f50bc Author: Xavier Chapron <[email protected]> Date: Mon May 29 17:15:13 2023 +0200 src: crypto.c: Simplify crypto_ecdsa_sign_sha256_hash_with_key() commit daa18285edaa8815d4fd19f4d3ea4f1a6769af19 Author: Xavier Chapron <[email protected]> Date: Mon May 29 16:36:21 2023 +0200 src: crypto.c: Simplify crypto_get_compressed_pubkey_at_path() commit 54b2831c6cb5f724aedab952dca5da59606d8097 Author: Xavier Chapron <[email protected]> Date: Mon May 29 16:36:00 2023 +0200 Makefile: Enable lib_standard_app crypto_helpers.c usage commit 6846a91cabbaaadd13f98347a6271d93163a7277 Author: Xavier Chapron <[email protected]> Date: Mon May 29 12:08:27 2023 +0200 Makefile: Revamp the Makefile using SDK Makefile.standard_app features This commit doesn't affect generated `bin/app.apdu` (same sha256sum). commit 8389ff5fef5c341dc0459e9a3082dd3b11519e8f Merge: 2531a8d 3e66f6e Author: Salvatore Ingala <[email protected]> Date: Fri May 26 18:18:48 2023 +0200 Merge pull request #163 from LedgerHQ/check-return-value Check return value of crypto_derive_private_key commit 3e66f6e16558fd93991f0fd9f1fc2e9715a85c07 Author: Salvatore Ingala <[email protected]> Date: Fri May 26 17:12:21 2023 +0200 Check return value of crypto_derive_private_key commit 141e58b0be5139657a5419bc0e1ab82f41df673a Author: Salvatore Ingala <[email protected]> Date: Fri May 26 10:07:14 2023 +0200 Fix encoding of thresh when n == 1 commit 960c2ab7d9c89e48a592d65cb1ad2dadb40db654 Author: Salvatore Ingala <[email protected]> Date: Fri May 26 09:40:21 2023 +0200 thresh has the 'd' and 'u' properties commit e5701a54c41a78575c4d99fd720088eb66ff2696 Author: Salvatore Ingala <[email protected]> Date: Fri May 26 09:38:18 2023 +0200 Add test for a complicated vault setup commit 2531a8dc04693cdc07a695a750426d8146129a05 Merge: cd83daf 1f1c6c9 Author: Salvatore Ingala <[email protected]> Date: Thu May 25 10:19:15 2023 +0200 Merge pull request #161 from LedgerHQ/152-signing-performance Avoid duplicate work on non-Stax devices commit 1f1c6c99445406903d6d3b651a98bebebdb78cf8 Author: Salvatore Ingala <[email protected]> Date: Wed May 24 14:41:38 2023 +0200 Only perform the dry-run for the outputs on Stax commit e8f053e932f89b584440f50f1c84ca12fdf8787a Author: Salvatore Ingala <[email protected]> Date: Wed May 24 13:50:47 2023 +0200 Update (c) notice, and improved dashboard wording for testnet app on Stax commit 16a2999c68cde7bc16927c97f1df401a6cd63f01 Author: Salvatore Ingala <[email protected]> Date: Wed May 24 11:49:10 2023 +0200 Refactor state related to outputs; remove unused variable; slightly simplify read_outputs commit cd83dafbe2cb2ed3bac27a141f2a399daa9c7477 Author: Salvatore Ingala <[email protected]> Date: Wed May 10 16:28:43 2023 +0200 Update CHANGELOG for version 2.1.2 commit 477361a53fddeedabf42a6fbf16a313b12a73f90 Merge: f45d8cc d6e1ba0 Author: Salvatore Ingala <[email protected]> Date: Fri May 5 14:18:26 2023 +0200 Merge pull request #160 from LedgerHQ/add-guidelines-enforcer Add guidelines enforcer to CI commit d6e1ba0c2069786d43bdde47789e0464909b27ac Author: Salvatore Ingala <[email protected]> Date: Fri May 5 09:55:26 2023 +0200 Add --curve and --path_slip21 params commit bc4bf10d172b70f09bd9c39be53bcbfd787bc349 Author: Salvatore Ingala <[email protected]> Date: Thu May 4 13:49:19 2023 +0200 Fix clang-analyzer issues commit dc59e4bae77a9bc9f29b4f0dd8734fe0d3475641 Author: Salvatore Ingala <[email protected]> Date: Thu May 4 12:02:19 2023 +0200 Add guidelines enforcer to CI commit f45d8ccf5c00fc5cae3670424cd8b33b17ff64a6 Merge: 64fc633 05014fa Author: Salvatore Ingala <[email protected]> Date: Tue May 2 15:12:18 2023 +0200 Merge pull request #158 from LedgerHQ/fbe/reset_BSS Reset BSS at start in swap mode commit 05014fa02457e7e9dcb99f21a127f05bb24c7d2d Author: Francois Beutin <[email protected]> Date: Tue May 2 13:37:10 2023 +0200 Reset BSS at start in swap mode commit 64fc633e2ea3f2aec75a1bef71686ef23edc93ba Merge: 308f51b 63d2ee0 Author: Salvatore Ingala <[email protected]> Date: Wed Apr 26 11:59:54 2023 +0200 Merge pull request #157 from LedgerHQ/fbe/add_ragger_test_filter Only run Swap tests related to Bitcoin commit 63d2ee0d5d4b05a68f73484567d216161d4b2bbe Author: Francois Beutin <[email protected]> Date: Wed Apr 26 11:23:28 2023 +0200 Only run Swap tests related to Bitcoin commit 308f51b88fa1a63a872e51cdf122e37cbed4e3f8 Merge: 4be654f bdc48a2 Author: Salvatore Ingala <[email protected]> Date: Tue Apr 25 17:52:51 2023 +0200 Merge pull request #156 from LedgerHQ/fbe/exchange_reusable_workflow Add a workflow triggering the Exchange tests with the current Bitcoin branch commit bdc48a2baef0c79d8d44ae5b33fa01512bc07a64 Author: Francois Beutin <[email protected]> Date: Tue Apr 25 17:39:15 2023 +0200 Add a workflow triggering the Exchange tests with the current Bitcoin branch commit 4be654ff5eec7d82cd7db1ecae53bd5839e49bd2 Merge: 83d5c28 068566c Author: Salvatore Ingala <[email protected]> Date: Fri Apr 21 17:07:31 2023 +0200 Merge pull request #142 from LedgerHQ/fix-addr-idx Check bound on address index in get_wallet_address commit 83d5c28eba29e278595abc3fc0f93525a1998a6a Merge: 0981826 a2f1632 Author: Salvatore Ingala <[email protected]> Date: Fri Apr 21 17:03:01 2023 +0200 Merge pull request #148 from LedgerHQ/fix-ux-glitch Fix get_extended_pubkey and get_wallet_address not returning to dashboard commit a2f1632102cd94c0556e85719f5a3da866322b06 Author: Salvatore Ingala <[email protected]> Date: Fri Apr 21 16:39:05 2023 +0200 Fix get_extended_pubkey and get_wallet_address not returning to dashboard when done commit 0981826f093ebfc8a4b451d291d1f07c461600c1 Merge: 1271309 22298b8 Author: Salvatore Ingala <[email protected]> Date: Thu Apr 20 09:43:37 2023 +0200 Merge pull request #147 from bitcoinerlab/new-synced-branch javascript: Improve usability for 3rd parties: update README, expose types, and remove unused dependency commit 22298b8710b03e5de6abee41fb06f95d640941e6 Author: José Luis Landabaso Díaz <[email protected]> Date: Wed Apr 19 16:27:41 2023 +0200 Expose PartialSignature for usage by 3rd parties commit c8de9256c21d0157689caa07f489e051d680174c Author: José Luis Landabaso Díaz <[email protected]> Date: Wed Apr 19 16:07:07 2023 +0200 Remove unused dependency tiny-secp256k1 from package.json commit 6e80438eb4708c0fa0e2947b7820e95364beeaf4 Author: José Luis Landabaso Díaz <[email protected]> Date: Wed Apr 19 16:05:30 2023 +0200 docs: Add official npm package information to bitcoin_client_js/README.md commit 12713094dabacc0afed5865be8b8ae37754ae247 Merge: 979a5f4 aca46bb Author: Salvatore Ingala <[email protected]> Date: Wed Apr 19 14:56:47 2023 +0200 Merge pull request #146 from LedgerHQ/pytest-timeout Add a default 5-min test timeout in ci commit aca46bb04680e15df5d2f06ef86ce994dc3c2737 Author: Salvatore Ingala <[email protected]> Date: Wed Apr 19 09:36:38 2023 +0200 Add a default 5-min test timeout in ci tests (except for very long tests, that are disabled by default) commit 979a5f49c8f0e7bca50e5225ee80e453750634b0 Author: Salvatore Ingala <[email protected]> Date: Tue Apr 18 16:36:04 2023 +0200 Slight refactoring of contains_a commit 4e0ffda9f99896fbad1c065c937336eecc59f1b9 Merge: f9673ef 8ff2f30 Author: Salvatore Ingala <[email protected]> Date: Tue Apr 18 16:06:08 2023 +0200 Merge pull request #141 from LedgerHQ/paranoidclient Reject policies that are not correctly implemented in certain app versions commit 8ff2f30cf742f42aed63b97809e31b7fa81380fe Author: Salvatore Ingala <[email protected]> Date: Tue Apr 18 15:30:56 2023 +0200 Bump python client to 0.2.1 and update CHANGELOG; bump js client to 0.2.1; bump rust client to 0.1.3 commit a09c8fea95367bd2e3a489926ea7f8ebcca5316a Author: Salvatore Ingala <[email protected]> Date: Mon Apr 17 14:29:32 2023 +0200 Update rust library to reject policies with 'a:' fragments in releases before 2.1.2 commit 2b937270bc8dab8e6d37d3a1bc2d4cfa8910d8e0 Author: Salvatore Ingala <[email protected]> Date: Mon Apr 17 12:05:52 2023 +0200 Test retrieving app name and version commit 5c6f03012a1201b68a6e175792a2e65151ab881f Author: Salvatore Ingala <[email protected]> Date: Mon Apr 17 11:41:06 2023 +0200 Update js library to reject policies with 'a:' fragments in releases before 2.1.2 commit 9b0d1e134313ff4c0a1d64b0d5ba006ad5b3ce77 Author: Salvatore Ingala <[email protected]> Date: Mon Apr 17 11:09:34 2023 +0200 Update python library to reject policies with 'a:' fragments in releases before 2.1.2. commit f9673ef7dc5f4b4bcde4f62e44e1c7df4dc803de Author: Salvatore Ingala <[email protected]> Date: Fri Apr 7 17:14:51 2023 +0200 Fix generated Script for miniscript a: wrapper; added test commit 068566c2a298b5fa50546eb2f28d85f4eb4b97b4 Author: Salvatore Ingala <[email protected]> Date: Tue Apr 4 17:28:27 2023 +0200 Check bound on address index in get_wallet_address commit 250b3270d67e2975d8103123226a3dd91be32cf5 Merge: a4603e1 2c8a1f5 Author: Salvatore Ingala <[email protected]> Date: Mon Apr 3 10:12:33 2023 +0200 Merge pull request #137 from LedgerHQ/fixpy Fix import in python client commit 2c8a1f5acbb85ea70c38cbca7fd4cea40cfa41b6 Author: Salvatore Ingala <[email protected]> Date: Mon Apr 3 09:57:54 2023 +0200 Delete unused file commit 145fe262e2afcfaa732f68054307708df18da8ff Author: Salvatore Ingala <[email protected]> Date: Mon Apr 3 09:56:52 2023 +0200 Fix botched import commit a4603e110b8fb4131863a61bd17bc886334f7a35 Merge: b2c6247 52e0d52 Author: Salvatore Ingala <[email protected]> Date: Fri Mar 31 17:49:48 2023 +0200 Merge pull request #136 from LedgerHQ/prepare-release Update changelog for version 2.1.2 commit 52e0d5256cc1acf6adb3840ef11f0791be7acfc7 Author: Salvatore Ingala <[email protected]> Date: Fri Mar 31 17:27:12 2023 +0200 Update changelog for version 2.1.2 commit b2c624769c3b863b38dd133e8facabb3d7b5b76c Merge: 192031a 4b199ce Author: Salvatore Ingala <[email protected]> Date: Fri Mar 31 16:17:32 2023 +0200 Merge pull request #133 from LedgerHQ/p1p2 Relax p1 to use it as an optional feature bitmap commit 4b199cef7deba7789298ed99b78b0ea4898d71de Author: Salvatore Ingala <[email protected]> Date: Fri Mar 31 14:52:21 2023 +0200 Add explicit constant for the protocol version; renamed p2 to protocol_version in all the handlers commit f46675a8f4596f566950bcadb547d7701f7fde16 Author: Salvatore Ingala <[email protected]> Date: Tue Mar 21 11:56:11 2023 +0100 Don't enforce p1=0 commit cffb0fc8f4d0e2cde7b1029b3c5d835438afe85f Author: Salvatore Ingala <[email protected]> Date: Tue Mar 21 11:31:45 2023 +0100 Test that the app correctly responds with WRONG_P1P2 if p2 > 1 commit 192031a0558dd784f69797ee21af5721a2825a10 Merge: 9d340ea 21e2a3c Author: Salvatore Ingala <[email protected]> Date: Fri Mar 31 14:25:43 2023 +0200 Merge pull request #128 from LedgerHQ/nonwitnessutxo Allow signing wrapped segwit inputs with missing non-witness-utxo commit 21e2a3c3e54e65dc7e8764861db8edf7a3e60f4f Author: Salvatore Ingala <[email protected]> Date: Mon Mar 27 10:40:12 2023 +0200 Update automation for Stax commit c16a01b54be86b6716b55ffe0c3e2d47d58ea096 Author: Salvatore Ingala <[email protected]> Date: Wed Mar 8 16:47:00 2023 +0100 Allow signing (with warning) for wrapped segwit inputs with missing non-witness-utxo commit 9d340ea2c221bd4b0d9840e847da439a93f4ff62 Merge: 2dcd5f4 5c184c5 Author: Salvatore Ingala <[email protected]> Date: Fri Mar 31 14:09:49 2023 +0200 Merge pull request #126 from LedgerHQ/stax-over-tapscript Stax over tapscript commit 2dcd5f4962c8a576fbbf93699212718ebc2e9951 Merge: 6de8d1c 07d337f Author: Salvatore Ingala <[email protected]> Date: Mon Mar 27 10:16:01 2023 +0200 Merge pull request #135 from LedgerHQ/put_back_blake2_ripemd Put back blake2 ripemd commit 07d337f8afdf76c07aa169ffd20907245d4377a0 Author: Thomas Joly <[email protected]> Date: Mon Mar 27 09:59:24 2023 +0200 Put back blake2 and ripemd hash algo This reverts commit 8824e8b75a79e22635c2440e3b357a5e996f8555. commit 6de8d1c879af01ff1c1a793319219fe257299ef8 Author: Salvatore Ingala <[email protected]> Date: Thu Mar 23 14:48:36 2023 +0100 Missing GET_MASTER_FINGERPRINT in APDU summary table commit e3603e8f975e2e1dff0c27816157d5a3fe9b8b5f Author: Salvatore Ingala <[email protected]> Date: Tue Mar 21 10:53:06 2023 +0100 Dependency no longer needed, and it now supports PSBTv0 commit 02af4fc5c6c36eb7213d5458551d74f44e4a5f8e Author: Salvatore Ingala <[email protected]> Date: Tue Mar 21 09:33:10 2023 +0100 Typo in comment commit 22383…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the earlier PR #184, which had issues due to a faulty rebase operation. Like the previous one, it aims to address issue #171 by implementing an enhanced validation method in the JavaScript client library. It validates the generated wallet addresses against the expected ones using the "@bitcoinerlab/descriptors" library. Here are the key updates:
Updated package.json to incorporate new dependencies "@bitcoinerlab/descriptors" and "@bitcoinerlab/secp256k1", and the latest version of "bitcoinjs-lib" to "^6.1.3".
Introduced a new test in appClient.test.ts to validate the generated address or throw an error if it doesn't match the expected one.
Made modifications in appClient.ts to integrate new imports. Changes have been made to the
AppClientclass to use these libraries for address validation. Some previous validations were removed as they are now handled more effectively with the new approach.In response to the review comments on the previous PR, I've:
registerWallet.validatePolicywithvalidateAddressand removedcontainsA.<M;N>format. Included a test case using this format for better clarity.For further context and details, please refer to the discussion and changes in the previous PR #184.