forked from tarassh/eos-ledger
-
Notifications
You must be signed in to change notification settings - Fork 10
Vaulta Rebrand and New Contract Support #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericpassmore
wants to merge
48
commits into
LedgerHQ:develop
Choose a base branch
from
VaultaFoundation:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2025 Force Merg Ledger HQ Feb 2025
…pdate - 2025 documentation update for testing ledger. - regenerated snapshots for minor off by one pixel difference in text - regenerated snapshots for flex which have better display of pagination where max pages > 10
… unknown/suspect when they data is not sufficient
Vaulta Rebrand and New Contract Support
This reverts commit 5d7c5ac.
…ions clarified allow unknown action renamed variables to match intention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EOS
has rebranded toVaulta
. This update changes the brand name and logos. App code changes were required. Tests have been added and re-organized to support old and new contract names.Security Review
Small code changes may require security review
Checklist
develop
Dependency
Depends on App-Database Update LedgerHQ/ledger-app-database#353
Details
EOS
is rebranding toVaulta
, with a new ticker symbolA
.wumpas
tests with bad transfer actions, and validated they came across asunknown
actionsledgered.Devices
nanos
from.toml
Action
in tests to accept straight hex-encoded data when provided.