Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Stellar: support non-native assets + custom fee #2223

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

quietbits
Copy link

@quietbits quietbits commented Feb 19, 2022

A few things to note:

  1. FIXED - Send amount screen doesn't work with a non-native asset. It looks like it is always using the native asset (XLM), even though it shows USDC. This affects the rest of the flow (mismatch between what we see on the screen and what is actually updating). For example, it is always showing XLM on the Ledger device.
  2. FIXED - Is there a way to add asset code and asset issuer conditional fields on the Send confirmation screen? We have added those fields to stellar/TransactionConfirmFields.js but they are not showing up. This may be also caused by the issue above.
  3. We used BTC fees as an example, but our use case is different. We're open to suggestions on how to improve it.
  4. We have been developing only on Android, so hopefully there will be no issues with iOS (we have no way of testing/developing for iOS).

Feedback is very welcome! 🙏

@quietbits quietbits requested review from a team as code owners February 19, 2022 01:35
@quietbits quietbits marked this pull request as draft February 19, 2022 01:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant