Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/LIVE-10694: add webview and feature flag for swap live app view in LLM #8314

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

kallen-ledger
Copy link
Contributor

@kallen-ledger kallen-ledger commented Nov 6, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This PR aims to add conditional rendering of the swap live app under the feature flag ptxSwapLiveAppMobile.
By default this is disabled, when enabled the swap view will be redirected to the swap live app instead of native.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@kallen-ledger kallen-ledger requested review from a team as code owners November 6, 2024 11:51
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 10:12am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 10:12am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 10:12am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 10:12am

@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Nov 6, 2024
liviuciulinaru
liviuciulinaru previously approved these changes Nov 6, 2024
andreicovaciu
andreicovaciu previously approved these changes Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants