Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: support CAL test pub key #8349

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Fix: support CAL test pub key #8349

wants to merge 16 commits into from
+93 −53

Conversation

sarneijim
Copy link
Contributor

@sarneijim sarneijim commented Nov 12, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Enable to use test and prod provider pub key for sell

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@live-github-bot live-github-bot bot added the common Has changes in live-common label Nov 12, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 11:44pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:44pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:44pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:44pm

@sarneijim sarneijim marked this pull request as ready for review November 12, 2024 16:31
@sarneijim sarneijim requested review from a team as code owners November 12, 2024 16:31
@sarneijim sarneijim changed the title Fix/support test cal Fix: support CAL test pub key with SELL Nov 13, 2024
CremaFR
CremaFR previously approved these changes Nov 13, 2024
View reviewed changes
KVNLS
KVNLS previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update file ownership, please? I think that Live Hub team might not be a reviewer for this change.

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Nov 13, 2024
@sarneijim sarneijim changed the title Fix: support CAL test pub key with SELL Fix: support CAL test pub key Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS left review comments

@CremaFR CremaFR Awaiting requested review from CremaFR

At least 1 approving review is required to merge this pull request.

Assignees

@sarneijim sarneijim

Labels
common Has changes in live-common desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarneijim @CremaFR @KVNLS