[DRAFT] Implement hmac for proving repeated code pages #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
For an e2e flow in the bitcoin V-App, the total transmitted data on Nano S+ goes from 407015+12927 to 321793+27053, about 17% reduction. For Nano X, from 767079+56228 to 567042+71809, about a 22% reduction. So not sure it's worth the added complexity at this time. Gains could be bigger if a model where the V-App is first installed (producing the hmac for all the code pages) is adopted. |
bigspider
force-pushed
the
fast_proofs
branch
2 times, most recently
from
d9d2d47 to
dd054f3
Compare
bigspider
changed the title
bigspider
force-pushed
the
fast_proofs
branch
from
dd054f3 to
10d7a38
Compare
Incomplete: using a placeholder instead of the actual HMAC (that should use a private key, possibly key deterministically crated from the app hash (this would allow stored HMACs to remain valid for future executions of the app). Exploratory commit to modify the protocol to compute an hmac before dropping a code page, so that the required data for pages sent multiple times is reduced; moreover, the client could (in principle) store it permanently for future executions of the V-App).
bigspider
force-pushed
the
fast_proofs
branch
from
10d7a38 to
f3865b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental PR to assess a possible improvement to the protocol:
This saves some bandwidth for repeated pages, especially on large/complex apps and on devices with smaller caches.