fix: improve compatibility with aatws #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was lazy in the past and "extended" GNOME's app switcher so that I didn't need to write the tiling popup from scratch. Besides the fact that this was a bad usage, it also caused compatibility issues with other extensions that modify the app switcher or switcher popup like aatws. As a quick fix, I've just pulled in the code from the app switcher and switcher popup from GNOME Shell into the extension. I only amended some import statements. It would be a nice idea to rewrite the tiling popup "properly". fixes: #381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was lazy in the past and "extended" GNOME's app switcher so that I didn't need to write the tiling popup from scratch. Besides the fact that this was a bad usage, it also caused compatibility issues with other extensions that modify the app switcher or switcher popup like aatws.
As a quick fix, I've just pulled in the code from the app switcher and switcher popup from GNOME Shell into the extension. I only amended some import statements. It would be a nice idea to rewrite the tiling popup "properly".
fixes: #381