Refactor/pydantic adjusts #1424
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic v2 and v1.10.17 have a
pydantic.v1
compatibility namespace/module that we can import everything we need from. This means that we only need a single interface (unfortunately, the old one) to be compatible with both versions.This is much cleaner, but I wouldn't be surprised if there's a slight performance drawback if the validation in the
v1
module only occurs in python instead of rust.