Feature/adjusts for optimas #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses coming in future
…k to APOSMM until either the entire initial sample is complete, or the subequent sample is
…..? do we assume thats the same as max_active_runs?
jlnav
commented
Sep 26, 2024
jlnav
commented
Sep 26, 2024
| return user["initial_sample_size"] if not self._told_initial_sample else user["max_active_runs"] | ||
|
|
||
| @property | ||
| def _enough_initial_sample(self): |
There was a problem hiding this comment.
is this necessary for non-optimas cases?
jlnav
commented
Sep 26, 2024
| if calc_in is not None: | ||
| self.y_new = np.atleast_2d(calc_in["f"]).T | ||
| nan_indices = [i for i, fval in enumerate(self.y_new) if np.isnan(fval)] | ||
| nan_indices = [i for i, fval in enumerate(self.y_new) if np.isnan(fval[0])] |
There was a problem hiding this comment.
why was this necessary for gpcam+optimas experiments but not libE ones?
jlnav
commented
Sep 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental/jlnav_plus_shuds_asktell #1433 +/- ##
=========================================================================
+ Coverage 76.25% 78.76% +2.51%
=========================================================================
Files 91 90 -1
Lines 8389 8280 -109
Branches 1492 1476 -16
=========================================================================
+ Hits 6397 6522 +125
+ Misses 1748 1527 -221
+ Partials 244 231 -13 ☔ View full report in Codecov by Sentry. |
…ta deal with getting a variable number of responses
Bumps [globus-compute-sdk](https://github.com/globus/globus-compute) from 2.27.1 to 2.28.0. - [Release notes](https://github.com/globus/globus-compute/releases) - [Changelog](https://github.com/globus/globus-compute/blob/main/docs/changelog.rst) - [Commits](globus/globus-compute@2.27.1...2.28.0) --- updated-dependencies: - dependency-name: globus-compute-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.24.6 to 1.25.0. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.24.6...v1.25.0) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…vering for similar-to-optimas asks and tells
…evelop/crate-ci/typos-1.25.0 Bump crate-ci/typos from 1.24.6 to 1.25.0
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…us-compute-sdk-2.28.0 Bump globus-compute-sdk from 2.27.1 to 2.28.0
…evelop/crate-ci/typos-1.26.0 Bump crate-ci/typos from 1.25.0 to 1.26.0
…s instead of Thread, to potentially prevent data mangling
… the persistent_gen - otherwise since it was slotted in the same point will get sent back again
…sults, not just the number we've buffered...
…a routine for subsequent runs that dont need slotting in anyway!!
shuds13
approved these changes
Oct 17, 2024
jlnav
merged commit dbd19fd
into
experimental/jlnav_plus_shuds_asktell
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tentative changes, mostly adjusts to the APOSMM class so it does internal buffering