Feature / save long-running sim outputs to cache. Manager preempts sending identical work in favor of pulling from cache #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or f) out of a given update-index to file.
… and then seeing if values exist in that cache before sending sims...
…he cache being created. iterate over the cache_keys corresponding to those in gen_specs out, then check if they're close to a cache entry. grab those indexes so we can slot in the corresponding data into the manager's H later on
…ve determined points_to_evaluate
…istory_f on/with those indexes and the associated cache values, pretending that the array of cache-values are a worker message
…rrides .recv, and in _send_work_order that forms a buffer from corresponding cache entries
…hed work. increment a cache_index for slotting into local buffer
…volving gen hang. only if all sim work already in cache do we skip the send-stage. when processing cache entries, process them in the order in which they presumptively would've been received from that worker. additional logging.
…asily accessible args
jlnav
changed the title
… tiny refactors to worker.py to help reuse a method. add CACHE_RETRIEVE tag
…formed cache data / H_rows from the cache
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1585 +/- ##
===========================================
- Coverage 93.36% 93.35% -0.01%
===========================================
Files 76 76
Lines 7580 7677 +97
Branches 1119 1141 +22
===========================================
+ Hits 7077 7167 +90
- Misses 329 331 +2
- Partials 174 179 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nce we're comparing to returned calc statuses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the docstrings of new functions for descriptions. I'm happy to explain anything.
TODO:
WORKER_SATISFIED_BY_CACHEor something"".join(sys.argv)(user specifies name)I'd appreciate local tests/feedback!