-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add butterworth filtered aperture functions and phase offset correction #75
Conversation
Both disk and line filter; used by default with hopefully reasonable parameters when creating `HoloParams`.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my 2 ct :-)
* Let `estimate_sideband_size` always return a `float` instead of an array type, to prevent incompatibilities with numba-based functions. * Make the line filter optional * Improve docstrings
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 39.92% 38.04% -1.88%
==========================================
Files 11 11
Lines 541 615 +74
Branches 29 42 +13
==========================================
+ Hits 216 234 +18
- Misses 314 371 +57
+ Partials 11 10 -1 ☔ View full report in Codecov by Sentry. |
This gives us at least coverage of disabled/enabled line filter in a smoke-testing fashion.
HoloParams
.pytest-snapshot
or similar to make sure things don't break underneath us without noticing)Contributor Checklist: