Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add butterworth filtered aperture functions and phase offset correction #75

Merged
merged 7 commits into from
Feb 18, 2025

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented Feb 14, 2025

  • Both disk and line filter; used by default with hopefully reasonable parameters when creating HoloParams.
  • Add phase offset correction, which is needed to properly average complex images
  • Tests are mostly smoke tests for now; we will need to develop a strategy how to handle some of the situations (one possibility would be to use pytest-snapshot or similar to make sure things don't break underneath us without noticing)

Contributor Checklist:

Both disk and line filter; used by default with hopefully reasonable
parameters when creating `HoloParams`.
@sk1p sk1p added the enhancement New feature or request label Feb 14, 2025
Copy link
Member

@uellue uellue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my 2 ct :-)

@sk1p sk1p changed the title Add butterworth filtered aperture functions Add butterworth filtered aperture functions and phase offset correction Feb 14, 2025
* Let `estimate_sideband_size` always return a `float` instead of an
  array type, to prevent incompatibilities with numba-based functions.
* Make the line filter optional
* Improve docstrings
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 58.22785% with 33 lines in your changes missing coverage. Please review.

Project coverage is 38.04%. Comparing base (1f5d01c) to head (165406b).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/libertem_holo/base/reconstr.py 8.33% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   39.92%   38.04%   -1.88%     
==========================================
  Files          11       11              
  Lines         541      615      +74     
  Branches       29       42      +13     
==========================================
+ Hits          216      234      +18     
- Misses        314      371      +57     
+ Partials       11       10       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sk1p added 2 commits February 18, 2025 11:16
This gives us at least coverage of disabled/enabled line filter in
a smoke-testing fashion.
@sk1p sk1p merged commit 14c89e0 into LiberTEM:master Feb 18, 2025
18 of 19 checks passed
@sk1p sk1p deleted the butterworth branch February 18, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants