Add a CI job that tests against pinned requirements #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As these requirements are the ones that end up in the docker container image, we should make updating the requirements testable. The installation tries to mimick what's done in the container build script as far as possible, but as it needs to install the `[test]` extra, it can't use `--no-deps` and thus isn't a 100% match.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 190
Branches ? 21
========================================
Hits ? 190
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
sk1p
force-pushed
the
test-pinned-requirements
branch
from
1d81cae
to
736c227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs TemGym/TemGym#35 for a clean CI run ✔️
As these requirements are the ones that end up in the docker container image, we should make updating the requirements testable. The installation tries to mimick what's done in the container build script as far as possible, but as it needs to install the
[test]extra, it can't use--no-depsand thus isn't a 100% match.Also fix incorrect git sha in the pinned requirements - it has to match the
pyproject.toml!Switch to
uvfor much faster CI run.