Conversation
…tter during recolor
…tter during recolor
f990e53 to
a48500e
Compare
Member
Author
|
I'm not sure why this didn't deploy automatically. Deployed to https://paint-in-place-for-real--liberatedpixelcup.netlify.app/ |
…al-LPC-Spritesheet-Character-Generator into paint-in-place-for-real
a48500e to
6b89076
Compare
Contributor
|
@Gaurav0 @jrconway3 I am done for now with this PR. I will need more details for other recolors, but there are a bunch of items being drawn on the fly now. |
907bdea to
81dda74
Compare
Merged
Member
Author
|
Closing in favor of #284 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not super familiar (or familiar at all) with this WebGL stuff but basically it goes like this:
2Dcontext canvas we have offscreen. This is then copied once again to the preview canvas, and is the one used for downloads and stuff.With CPU pixel by pixel it takes 190ms-230ms. With GPU it takes around 90ms-130ms.
The improvements are there and seem to be working. I may not be using the optimal setup tho.