Skip to content

Issue #209/#234 Implemented Advanced Paint in Place Options w/Multiple Recolors#313

Closed
jrconway3 wants to merge 130 commits intoLiberatedPixelCup:paint-in-place-masterfrom
jrconway3:feature/issue-234-paint-in-place-optional-variants-generate
Closed

Issue #209/#234 Implemented Advanced Paint in Place Options w/Multiple Recolors#313
jrconway3 wants to merge 130 commits intoLiberatedPixelCup:paint-in-place-masterfrom
jrconway3:feature/issue-234-paint-in-place-optional-variants-generate

Conversation

@jrconway3
Copy link
Contributor

@jrconway3 jrconway3 commented Feb 19, 2026

I literally just finished the last couple of things, very possible there's some crap I missed but I'd like some reviews.

I have finally gotten the ability to replace Eye Color on the same asset as skintone (heads). I'm also quite fond of how the recolor modal works, I spent a lot of time fine-tuning this.

Github Copilot was used to help get started so I could more easily figure out how the infrastructure works as I'm not familiar with Mithril. I'm getting more used to it now, though.

Preview of how recolors work:
image

I took inspiration from Vitruvian for the modal design:
https://vitruvianstudio.github.io/

Originally I used two small squares for the palettes, but I opted to swap it to showing the full palette because I had enough real estate to do so.

JaidynReiman added 30 commits January 12, 2026 01:43
…ons & Materials In Metadata Instead of Constants
@jrconway3
Copy link
Contributor Author

Merged conflicts now. Just need to see if Copilot comes up with anything else. So far everything seems to be working...

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 154 out of 2779 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jrconway3 jrconway3 requested a review from Gaurav0 February 27, 2026 15:37
@Gaurav0
Copy link
Member

Gaurav0 commented Feb 28, 2026

Overall, this looks good enough to iterate on. However, I feel the PR is too big to do a proper code review.

The major gripe I have is now we can't see what the variant actually looks like anymore.

Before:

Screenshot 2026-02-27 at 11 17 59 PM

After:

Screenshot 2026-02-27 at 11 14 41 PM

I liked being able to see a preview of the variants and pick from them. I'm not sure we can squeeze that into the new modal?

@jrconway3
Copy link
Contributor Author

Once you toggle the palette, it toggles the preview as well.

However....

Once theory could be reworking the structure to have it be columns + rows like the old variants setup. Have the color appear above and just show the image below. We probably wouldn't need to show off the palette swatch, but in theory it might even be possible to still include it that way.

@Gaurav0
Copy link
Member

Gaurav0 commented Feb 28, 2026

Bug with compact display:

Screenshot 2026-02-27 at 11 24 55 PM

@jrconway3
Copy link
Contributor Author

However, I feel the PR is too big to do a proper code review.

I screwed this up by trying to fix a few additional assets. Those "few additional assets" just ended up making massive amounts of unnecessary extra changes because I cleaned out duplicate files and moved some files around to clean up the file structure.

@jrconway3
Copy link
Contributor Author

jrconway3 commented Feb 28, 2026

Overall, this looks good enough to iterate on. However, I feel the PR is too big to do a proper code review.
#330

This version of the PR makes it much cleaner so we can see the code changes better. I opted not to merge that one into this for now, but I can merge it into here if you prefer and we can do the image restructure later.

@jrconway3
Copy link
Contributor Author

Bug with compact display:

Screenshot 2026-02-27 at 11 24 55 PM

Looks like this was created by the parent branch's changes. Its happening on variant style assets, too.

@jrconway3
Copy link
Contributor Author

I'll resume this later, but here's the next things I will do:

  1. Figure out why compactDisplay is screwing up and fix it.
  2. Create a new branch containing a version of the modal where we use a grid view similar to variants and display the preview image with each color version.

@jrconway3
Copy link
Contributor Author

Fixed Compact Display.

@jrconway3 jrconway3 changed the title WIP: Issue #209/#234 Implemented Advanced Paint in Place Options w/Multiple Recolors Issue #209/#234 Implemented Advanced Paint in Place Options w/Multiple Recolors Mar 2, 2026
@jrconway3
Copy link
Contributor Author

Alternate modal containing previews for each image: #335

@Gaurav0
Copy link
Member

Gaurav0 commented Mar 4, 2026

Will review again once the modal branch is merged.

@jrconway3
Copy link
Contributor Author

I merged them over here:
#330

If its preferred we can just stick with that one and worry about the file restructure later.

@jrconway3
Copy link
Contributor Author

The file restructure will be done later in a separate PR.

@jrconway3 jrconway3 closed this Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants