Refactor: Cleanup Ear Assets#340
Open
jrconway3 wants to merge 4 commits intoLiberatedPixelCup:paint-in-place-masterfrom
Open
Refactor: Cleanup Ear Assets#340jrconway3 wants to merge 4 commits intoLiberatedPixelCup:paint-in-place-masterfrom
jrconway3 wants to merge 4 commits intoLiberatedPixelCup:paint-in-place-masterfrom
Conversation
✅ Deploy Preview for liberatedpixelcup ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors furry ear skintone assets by consolidating/removing redundant assets and aligning directory layout with the project’s standard (adult/fg, adult/bg, etc.).
Changes:
- Updated cat/wolf skintone sheet definitions to point at the new
adult|child/{fg,bg}directories - Updated
z_positions.csvanditem-metadata.jsto match the new asset paths - Updated
CREDITS.csventries to reflect moved/renamed assets
Reviewed changes
Copilot reviewed 5 out of 9057 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sheet_definitions/head/furry_ears/top/head_ears_wolf_skin.json | Updates asset directory references; adjusts one animation identifier |
| sheet_definitions/head/furry_ears/top/head_ears_cat_skin.json | Updates asset directory references; adjusts one animation identifier |
| scripts/zPositioning/z_positions.csv | Updates z-position path mappings for moved cat/wolf skintone assets |
| item-metadata.js | Updates embedded metadata to match new directories and animation identifier |
| CREDITS.csv | Updates credited filenames for moved cat/wolf skintone assets (including the backslash/bgslash entry) |
Comments suppressed due to low confidence (2)
item-metadata.js:1
- The metadata now references
"1h/bgslash"as an animation identifier. If the runtime expects animation names to be simple keys (matching prior values like1h_backslash), the slash can cause failed asset resolution or mismatched animation selection. Recommend reverting to a consistent key format (underscore-based) and updating the credited/asset filenames to match that decision.
// THIS FILE IS AUTO-GENERATED. PLEASE DON'T ALTER IT MANUALLY
CREDITS.csv:1
- These credited filenames introduce a
1h/subdirectory only for the backslash/bgslash asset, while other animations remain flat (e.g.,.../1h_slash.png). This asymmetry strongly suggests an accidental_→/change rather than an intentional directory split. If the intent was just to rename the animation/file, consider keeping it flat and underscore-based (e.g.,.../1h_bgslash.pngor keep.../1h_backslash.png) to match the rest of the asset set and avoid special-case paths.
filename,notes,authors,licenses,urls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am going to start dropping a handful of these, but they do not have to be merged into paint-in-place-master. If we merge that one to master first this can be merged into master instead.
For the first one, I removed all the recolor assets for ear skintones.
Also, some ear assets had split directories that were duplicates and didn't need to exist. These splits happened due to extra files that happened before the asset split script was run.
I also renamed the
adult_backandchild_front, etc, directories so its nowadult/fgorchild/bg, which is in line with other directory structures.Other than the directory structure change, everything else in here is just removing extra unneeded assets.