Skip to content

Refactor: Cleanup Ear Assets#340

Open
jrconway3 wants to merge 4 commits intoLiberatedPixelCup:paint-in-place-masterfrom
jrconway3:refactor/cleanup-ear-assets
Open

Refactor: Cleanup Ear Assets#340
jrconway3 wants to merge 4 commits intoLiberatedPixelCup:paint-in-place-masterfrom
jrconway3:refactor/cleanup-ear-assets

Conversation

@jrconway3
Copy link
Contributor

I am going to start dropping a handful of these, but they do not have to be merged into paint-in-place-master. If we merge that one to master first this can be merged into master instead.

For the first one, I removed all the recolor assets for ear skintones.

Also, some ear assets had split directories that were duplicates and didn't need to exist. These splits happened due to extra files that happened before the asset split script was run.

I also renamed the adult_back and child_front, etc, directories so its now adult/fg or child/bg, which is in line with other directory structures.

Other than the directory structure change, everything else in here is just removing extra unneeded assets.

Copilot AI review requested due to automatic review settings March 9, 2026 16:01
@jrconway3 jrconway3 added the refactor changes internal implementation label Mar 9, 2026
@netlify
Copy link

netlify bot commented Mar 9, 2026

Deploy Preview for liberatedpixelcup ready!

Name Link
🔨 Latest commit c0ca268
🔍 Latest deploy log https://app.netlify.com/projects/liberatedpixelcup/deploys/69aeefeda7fd290008ad702e
😎 Deploy Preview https://deploy-preview-340--liberatedpixelcup.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jrconway3 jrconway3 moved this to In Progress in Full rewrite Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors furry ear skintone assets by consolidating/removing redundant assets and aligning directory layout with the project’s standard (adult/fg, adult/bg, etc.).

Changes:

  • Updated cat/wolf skintone sheet definitions to point at the new adult|child/{fg,bg} directories
  • Updated z_positions.csv and item-metadata.js to match the new asset paths
  • Updated CREDITS.csv entries to reflect moved/renamed assets

Reviewed changes

Copilot reviewed 5 out of 9057 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sheet_definitions/head/furry_ears/top/head_ears_wolf_skin.json Updates asset directory references; adjusts one animation identifier
sheet_definitions/head/furry_ears/top/head_ears_cat_skin.json Updates asset directory references; adjusts one animation identifier
scripts/zPositioning/z_positions.csv Updates z-position path mappings for moved cat/wolf skintone assets
item-metadata.js Updates embedded metadata to match new directories and animation identifier
CREDITS.csv Updates credited filenames for moved cat/wolf skintone assets (including the backslash/bgslash entry)
Comments suppressed due to low confidence (2)

item-metadata.js:1

  • The metadata now references "1h/bgslash" as an animation identifier. If the runtime expects animation names to be simple keys (matching prior values like 1h_backslash), the slash can cause failed asset resolution or mismatched animation selection. Recommend reverting to a consistent key format (underscore-based) and updating the credited/asset filenames to match that decision.
// THIS FILE IS AUTO-GENERATED. PLEASE DON'T ALTER IT MANUALLY

CREDITS.csv:1

  • These credited filenames introduce a 1h/ subdirectory only for the backslash/bgslash asset, while other animations remain flat (e.g., .../1h_slash.png). This asymmetry strongly suggests an accidental _/ change rather than an intentional directory split. If the intent was just to rename the animation/file, consider keeping it flat and underscore-based (e.g., .../1h_bgslash.png or keep .../1h_backslash.png) to match the rest of the asset set and avoid special-case paths.
filename,notes,authors,licenses,urls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor changes internal implementation

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants