* Fixed Clearing State of Primary Color Asset#341
Merged
jrconway3 merged 1 commit intoLiberatedPixelCup:paint-in-place-masterfrom Mar 9, 2026
Merged
Conversation
✅ Deploy Preview for liberatedpixelcup ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jrconway3
merged commit 98fbc49
into
LiberatedPixelCup:paint-in-place-master
8 of 9 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how palette recolor selections are grouped when selecting a color, with the goal of preventing the “primary color” selection state from being cleared unexpectedly during palette interactions.
Changes:
- Updates the selection-group key used when determining whether a palette option is already selected.
- Removes an explicit
m.redraw()call after recolor selection (relying on Mithril’s event redraw behavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed this:
From paint-in-place-master:
#284 (comment)
Example:
