[ARRISEOS-47239]: Cloned from Apple Radar 119814367: Mute functionality not working on video element #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suresh-khurdiya-infosys
force-pushed
the
suresh/ARRISEOS-47239
branch
from
ebed03e to
d209e60
Compare
suresh-khurdiya-infosys
requested review from
amol-virnodkar-infosys,
marcin-mielczarczyk-red and
pradeep-raveendranpillai-infosys
pradeep-raveendranpillai-infosys
previously approved these changes
Mar 18, 2025
marcin-mielczarczyk-red
previously approved these changes
Mar 18, 2025
suresh-khurdiya-infosys
dismissed stale reviews from marcin-mielczarczyk-red and pradeep-raveendranpillai-infosys
via
8bfb961
suresh-khurdiya-infosys
force-pushed
the
suresh/ARRISEOS-47239
branch
from
d209e60 to
8bfb961
Compare
marcin-mielczarczyk-red
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXTERNAL: Liberty Global: Mute functionality not working on video element
Created by Armand Adams on 18 December 2023 at 16:01
Edited by Armand Adams on 18 December 2023 at 16:01
Reason for clone: Cloning to external for partner review.
Summary: Mute functionality is broken on the video element causing Audio during Trickplay as well as the setting for muting audio on auto play videos to not work. We need the partner to investigate this.
Steps To Reproduce: 1. Launch App 2. Play Elephant Queen 3. Trickplay
ACTUAL: Audio heard during Trickplay
EXPECTED: No audio heard during Trickplay
Steps To Reproduce: 1. Launch ATV+ app, 2. Navigate to Settings tab, 3. scroll down to “Autoplay Video Sound” and set toggle to OFF, 4. Navigate to TV+ tab 5. Allow background video to play on the epic stage
ACTUAL: Video sound for background trailers remains ON when Autoplay Video Sound setting is set to OFF
EXPECTED: Video sound for background trailers is off when Autoplay Video Sound setting is set to OFF
3rd case:
-document.querySelector("video").volume = 0 to mute the audio