Refactor memcr-client code to create libmemcrclient.so licensed as LG… #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poopi
reviewed
Feb 6, 2025
COPYING
Outdated
| ================================================================================ | ||
|
|
||
| memcrclient_proto.h and libmemcrclient shared libarary are licensed by | ||
| Global Service B.V. under the GNU Lesser General Public License version 2.1 |
Poopi
reviewed
Feb 6, 2025
| Please use the following copyright for source for libmemcrlient shared library | ||
| source code: | ||
|
|
||
| Copyright (C) <YEAR> <NAME> |
Contributor
Author
There was a problem hiding this comment.
this is an example of the header (similarly in as GPL part), those tags are supposed to be filled in by proper values when used in a new source code
meecash
force-pushed
the
libmemcrclient
branch
from
ea8ef65 to
cf7d7e4
Compare
goruklu
approved these changes
Feb 13, 2025
bcatrysse
approved these changes
Feb 18, 2025
mkozlowski
reviewed
Feb 18, 2025
Makefile
Outdated
|
|
||
|
|
||
| all: $(B)/memcr $(B)/memcr-client | ||
| all: $(B)/memcr $(B)/memcr-client ${B}/libmemcrclient.so |
Collaborator
There was a problem hiding this comment.
would be good to stick to parenthesis style already used in this file
Makefile
Outdated
| @stat -c "-> %n: %s bytes <-" $@ | ||
| @size $@ | ||
|
|
||
| ${B}/libmemcrclient.o: libmemcrclient.c |
meecash
force-pushed
the
libmemcrclient
branch
from
cf7d7e4 to
68a85f6
Compare
meecash
force-pushed
the
libmemcrclient
branch
from
68a85f6 to
24f123a
Compare
mkozlowski
approved these changes
Feb 18, 2025
adrianM27
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…PL2.1