Restore retry #107
Closed
Restore retry #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Log what failed and for which VM * Kill PID on error * Verify restored VM size
Collaborator
|
Restore should not need to retry - it should work first time or fail if there is a problem. What problem are you trying to solve with this? As for vmr I prefer to keep it in memory dump as it reduces memcr memory usage. If there is a technical issue with this approach then let me know and we'll fix it. Memory dump is checksummed (if needed) so if vmr gets corrupted it will be detected and memcr will report an error. |
Contributor
Author
|
Closing, since no strong arguments to deliver it. Will reopen once needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rretry the restore up to 3 times.
Also, the vm_region struct isn’t dumped - it stays in the memcr worker process memory. That is to avoid potential corruption. Since dumps are fully tied to the running memcr instance anyway, there is no real need to include it.
Downside: each memcr process uses a bit more memory, up to around 200 KB more.