Read bufs moved to heap #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Log what failed and for which VM * Kill PID on error * Verify restored VM size
adrianM27
force-pushed
the
read_bufs_moved_to_heap
branch
from
79fd723 to
80727de
Compare
adrianM27
force-pushed
the
read_bufs_moved_to_heap
branch
from
80727de to
75f18fc
Compare
Collaborator
|
Using stack here is fine as the buffer size of ~1MB is relatively low and it results in a simpler code. It is also thread safe while global heap pointer is not. Another approach would be to provide heap allocated buffer pointer as a context when calling compress functions but this makes API more complex so I decided to go with the stack buffer. Is there any technical issue with the current approach? |
Contributor
Author
|
Closing, since no strong arguments to deliver it. Will reopen once needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data buffer for page upload during Restore and data buffer for compression/decompression moved to heap