[RFC] change uboot_help to build_matrix #6427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to have a way to identify all the possible build combinations within a single file. The uboot_helper was essential a list of all the combinations of builds (that used uboot). I've co-opted this to support all the projects/devices. I've also added the ability to get the arch for each device.
This changes the behaviour a little bit. I think it made the most sense but it may be worth looking into refactoring the helper yet again to make it suit our needs even more.
I've mainly made this change as a good way to identify all the possible build combinations so we can automatically populate the CI builds. With this change we will be able to automatically (and logically) create jobs for each project/device. We may also want to have something similar for the add-on build combinations.
Other future improvements may be to add a list of possible archs (arm + aarch64) but not many devices support this.
Github makes the diff a bit weird so it's probably best to look at each commit individually. The big commit should be looked at with whitespace changes off 7a54ccc?w=1