Run unit tests in CI #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notartom
force-pushed
the
unit-tests-in-ci
branch
2 times, most recently
from
b766f60 to
064401e
Compare
Now that LibriVox/librivox-catalog#190 has merged, we can actually run in CI. We also lay down some groundwork to make the workflow reusable, and to make the catalog branch checkout configurable, with the intention of running it against unmerged PRs. This means we have to call our own reusable workflow with the correct value of catalog_git_branch set, which is weird, but I couldn't find a more sane way to handle variable with GitHub Actions.
notartom
force-pushed
the
unit-tests-in-ci
branch
from
064401e to
4d97d34
Compare
|
Because this calls a reusable workflow that doesn't exist until we actually merge this PR, let's just merge and see what happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that LibriVox/librivox-catalog#190 has
merged, we can actually run in CI. Running it on librivox-catalog PRs
will come later, for now just proove this out on master.