Skip to content

Add catalog keywords cache update cron #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

notartom
Copy link
Member

FUP to and needed by LibriVox/librivox-catalog#231

Comment on lines 70 to 71
name: CodeIgniter sessions cleanup (hourly)
minute: "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this one doesn't really need to be run all that often, I think we'd avoid some busywork by batching it with the nightly cron jobs here:
https://github.com/LibriVox/librivox-ansible/blob/master/roles/common/files/daily-cron

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to fix the name - it should be Keywords update - but also, why nightly? How often are keywords added?

@jmsmallheer
Copy link

jmsmallheer commented May 13, 2025 via email

@redrun45
Copy link
Contributor

redrun45 commented May 13, 2025

Update:
Well, I've been looking at the keywords stats, rather than the keywords cache. Long story short, though, I think we want both of these to update at the same time as the nightly search index. We don't need a brand new keyword to be offered as a suggestion, until the project it's tied to is a viable search result!

Here's an equivalent line to update the stats, as well:
php /librivox/www/librivox.org/catalog/public_html/index.php cron Keywords_stats update_keywords_stats

@notartom notartom merged commit 7547ab0 into LibriVox:master May 14, 2025
1 check passed
@notartom notartom deleted the fup-231 branch May 14, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants