load_and_raise change #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aceer121
requested review from
lantiga,
aniketmaurya,
awaelchli and
Andrei-Aksionov
as code owners
for more information, see https://pre-commit.ci
|
Hi @Aceer121, thanks for the PR! please add a proper PR description. LitServe needs to follow Lightning AI's guidelines for production-ready OSS software.
thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
===================================
Coverage 81% 82%
===================================
Files 13 13
Lines 1036 1055 +19
===================================
+ Hits 842 862 +20
+ Misses 194 193 -1 |
| @@ -87,10 +96,15 @@ async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: | |||
|
|
|||
| async def rcv() -> Message: | |||
| nonlocal total_size | |||
| message = await receive() | |||
| try: | |||
| message = await receive() | |||
There was a problem hiding this comment.
could you please mention if we really need try...except here?
|
hi @Aceer121, please let me know if you need any help? |
|
closing this PR due to no response from the author! Please feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
I improved the error handling a bit, take a look