separate loops to new module loops.py#249
Merged
aniketmaurya merged 4 commits intomainfrom Aug 30, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
===================================
Coverage 84% 85%
===================================
Files 13 14 +1
Lines 1056 1081 +25
===================================
+ Hits 890 914 +24
- Misses 166 167 +1 |
awaelchli
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
Describe (in plain English, not technical Jargon) how this improves the user experience. If you can't tie it back to a real tangible, user goal or describe it in plain english, it's a hint that this is likely not needed and is probably an "engineering nit".
GOOD:
"As a user, I need to serve models faster. This PR focuses on enabling speed gains by using GPUs"
BAD:
"This PR enables GPUs".
This is bad because the user problem is not clear... instead it just jumps to the solution without any context.
PRs without this will not be merged.
What does this PR do?
Fixes # (issue).
server.pyhas grown in size and loops are going to have more logic in future. This PR separates loops in as its own module.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃