Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate loops to new module loops.py #249

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

⚠️ How does this PR impact the user? ⚠️

Describe (in plain English, not technical Jargon) how this improves the user experience. If you can't tie it back to a real tangible, user goal or describe it in plain english, it's a hint that this is likely not needed and is probably an "engineering nit".

GOOD:

"As a user, I need to serve models faster. This PR focuses on enabling speed gains by using GPUs"

BAD:

"This PR enables GPUs".
This is bad because the user problem is not clear... instead it just jumps to the solution without any context.

PRs without this will not be merged.


What does this PR do?

Fixes # (issue).

server.py has grown in size and loops are going to have more logic in future. This PR separates loops in as its own module.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 77.24868% with 43 lines in your changes missing coverage. Please review.

Project coverage is 85%. Comparing base (c1b6ad4) to head (a200872).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #249   +/-   ##
===================================
  Coverage    84%    85%           
===================================
  Files        13     14    +1     
  Lines      1056   1081   +25     
===================================
+ Hits        890    914   +24     
- Misses      166    167    +1     

@aniketmaurya aniketmaurya self-assigned this Aug 30, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aniketmaurya aniketmaurya merged commit 15e5f3d into main Aug 30, 2024
20 checks passed
@aniketmaurya aniketmaurya deleted the aniket/reorg-loops branch August 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants