Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add litserve.loops tests #257

Merged
merged 13 commits into from
Sep 3, 2024
Merged

add litserve.loops tests #257

merged 13 commits into from
Sep 3, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Aug 30, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

⚠️ How does this PR impact the user? ⚠️

No direct impact, it increases the test coverage.

GOOD:

"As a user, I need to serve models faster. This PR focuses on enabling speed gains by using GPUs"

BAD:

"This PR enables GPUs".
This is bad because the user problem is not clear... instead it just jumps to the solution without any context.

PRs without this will not be merged.


What does this PR do?

add litserve.loops tests

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya changed the title WIP add litserve.loops tests [WIP] add litserve.loops tests Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95%. Comparing base (5a2e8ec) to head (d1f725a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #257   +/-   ##
===================================
+ Coverage    92%    95%   +2%     
===================================
  Files        14     14           
  Lines      1082   1082           
===================================
+ Hits        999   1023   +24     
+ Misses       83     59   -24     

@aniketmaurya aniketmaurya changed the title [WIP] add litserve.loops tests add litserve.loops tests Sep 3, 2024
@williamFalcon williamFalcon merged commit 56c9f17 into main Sep 3, 2024
20 checks passed
@williamFalcon williamFalcon deleted the aniket/test-loops branch September 3, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants