Feat: multiple endpoints using a list of LitServer#276
Feat: multiple endpoints using a list of LitServer#276bhimrazy wants to merge 42 commits intoLightning-AI:mainfrom
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
===================================
Coverage 95% 95%
===================================
Files 14 14
Lines 1082 1143 +61
===================================
+ Hits 1025 1085 +60
- Misses 57 58 +1 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nto feat/multi-endpoints
williamFalcon
left a comment
There was a problem hiding this comment.
ok, let's pause this for now while we validate with customers what is a real use case...
rushing into something will only complicate the codebase, without no real user proof of exactly what problems this solves for them...
this feels very "theoretical" at this stage... i want to root this with user feedback first @lantiga @aniketmaurya
|
still can't use this function |
|
In the meantime , this gets merged , is there any other way to run multiple endpoints in one main server ? |
|
this is paused and not scheduled to be merged until we have a very clear usecase. so, the best way to unblock this is to share code of what you are trying to do and why you wouldn’t just run two separate servers on the same machine? |
|
hi! do you know when this PR will be merged? thanks |
Hi @raulcarlomagno, If this feature is crucial for your use case, you can consider using this snippet from this PR. It should help you achieve the desired functionality for now. |
|
thumbs up for this piece of art 👍 |
|
Closing this PR for now. Issue #271 will be addressed soon in a separate PR. There is an ongoing discussion around it, and since this PR is quite old and the implementation might take a different approach, it's better to start fresh with a new PR. |
Before submitting
As a user, I want to host multiple endpoints for different purposes, such as serving an embedding API, prediction API, etc., on the same server while maintaining LitServer features.
What does this PR do?
Fixes #271.
Usage
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃