Skip to content

Add custom healthcheck path #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

akuma12
Copy link
Contributor

@akuma12 akuma12 commented Oct 23, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs? - I would if I knew where to do that.
  • Did you write any new necessary tests?

What does this PR do?

Fixes #341 by adding a healthcheck_path property to the LitServer class, defaulting to the current path of /health.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

I did!

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96%. Comparing base (e23469c) to head (14077f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #342   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        22     22           
  Lines      1408   1411    +3     
===================================
+ Hits       1345   1348    +3     
  Misses       63     63           

@akuma12 akuma12 requested a review from Borda November 12, 2024 16:56
Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience @akuma12! This looks great 🚀

@aniketmaurya aniketmaurya merged commit 0c19861 into Lightning-AI:main Nov 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom path option for healthcheck
3 participants