Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAISpec with continuous batching loop #395

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

What does this PR do?

OpenAI Spec endpoints requires the inference worker response to be of type JSON str. This PR, formats the encoded_response before putting them in the queue.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88%. Comparing base (ca9d8c9) to head (60799d8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #395   +/-   ##
===================================
- Coverage    88%    88%   -0%     
===================================
  Files        25     25           
  Lines      1774   1775    +1     
===================================
  Hits       1560   1560           
- Misses      214    215    +1     

@aniketmaurya aniketmaurya merged commit e71f38b into main Dec 16, 2024
20 of 21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/fix-openai branch December 16, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants