Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set LitServer.stream using LitSpec.stream #398

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

What does this PR do?

Users will be able to create their own Spec and define streaming behavior for their Spec.

Fixes #397

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya enabled auto-merge (squash) December 17, 2024 14:01
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91%. Comparing base (fcce973) to head (373c8b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #398   +/-   ##
===================================
  Coverage    91%    91%           
===================================
  Files        25     25           
  Lines      1777   1782    +5     
===================================
+ Hits       1622   1627    +5     
  Misses      155    155           

@aniketmaurya aniketmaurya merged commit 636c9fd into main Dec 17, 2024
20 of 21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/spec-set-stream branch December 17, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make stream setable by spec
6 participants