Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for stream=False with yield usage #402

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jan 8, 2025

What does this PR do?

This PR, protects users from making mistake before starting the server and removes a redundant code.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89%. Comparing base (e9b1ee1) to head (0eb4388).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #402   +/-   ##
===================================
- Coverage    89%    89%   -0%     
===================================
  Files        30     30           
  Lines      1902   1893    -9     
===================================
- Hits       1692   1683    -9     
  Misses      210    210           

@aniketmaurya aniketmaurya changed the title add validation for stream=False and yield usage add validation for stream=False with yield usage Jan 8, 2025
@aniketmaurya aniketmaurya enabled auto-merge (squash) January 9, 2025 14:33
src/litserve/loops/base.py Outdated Show resolved Hide resolved
src/litserve/loops/base.py Outdated Show resolved Hide resolved
@aniketmaurya aniketmaurya merged commit 747308a into main Jan 9, 2025
19 checks passed
@aniketmaurya aniketmaurya deleted the litapi-validation branch January 9, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants