Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move built in loops inside classes #409

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jan 10, 2025

What does this PR do?

Move built in loops inside classes for a uniform code pattern and readability. This will help improve the socket encapsulation.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 76.54321% with 38 lines in your changes missing coverage. Please review.

Project coverage is 88%. Comparing base (6f1d3df) to head (396225e).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #409   +/-   ##
===================================
- Coverage    88%    88%   -1%     
===================================
  Files        30     30           
  Lines      1946   1987   +41     
===================================
+ Hits       1715   1740   +25     
- Misses      231    247   +16     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant