Skip to content

move built in loops inside classes#409

Merged
aniketmaurya merged 3 commits intomainfrom
aniket/multi-process-zmq
Jan 13, 2025
Merged

move built in loops inside classes#409
aniketmaurya merged 3 commits intomainfrom
aniket/multi-process-zmq

Conversation

@aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jan 10, 2025

What does this PR do?

Move built in loops inside classes for a uniform code pattern and readability. This will help improve the socket encapsulation.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 76.54321% with 38 lines in your changes missing coverage. Please review.

Project coverage is 88%. Comparing base (6f1d3df) to head (396225e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #409   +/-   ##
===================================
- Coverage    88%    88%   -1%     
===================================
  Files        30     30           
  Lines      1946   1987   +41     
===================================
+ Hits       1715   1740   +25     
- Misses      231    247   +16     

Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I read it corretly it is just minor refactoring when the 1:1 functionality is moved to class...

@aniketmaurya
Copy link
Collaborator Author

right @Borda

@aniketmaurya aniketmaurya merged commit 23bcb30 into main Jan 13, 2025
19 of 20 checks passed
@aniketmaurya aniketmaurya deleted the aniket/multi-process-zmq branch January 13, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants