Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward strict loading option from lightning module to deepspeed #152

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Forward strict loading option from lightning module to deepspeed #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2529e88
Forward strict loading option from lightning module to deepspeed
jyothisambolu Feb 12, 2024
a3a84e2
Update changelog
jyothisambolu Feb 12, 2024
2da6277
Merge branch 'main' into lightning_compatibility
jerome-habana Mar 19, 2024
1692638
Merge branch 'main' into lightning_compatibility
Borda Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed fabric imports for HPU strategies ([#126](https://github.com/Lightning-AI/lightning-Habana/pull/126))
- Enabling tests and examples of fabric with HPU ([#139](https://github.com/Lightning-AI/lightning-Habana/pull/139))
- Fixes an API break due to non-strict loading in Trainer ([#150](https://github.com/Lightning-AI/lightning-Habana/pull/150))
- Forward strict loading option from lightning module to deepspeed ([#152](https://github.com/Lightning-AI/lightning-Habana/pull/152))

### Removed

Expand Down
5 changes: 4 additions & 1 deletion src/lightning_habana/pytorch/strategies/deepspeed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,10 @@ def load_checkpoint(self, checkpoint_path: _PATH) -> Dict[str, Any]:

is_fitting = self.lightning_module.trainer.state.fn == TrainerFn.FITTING
_, client_state = self.deepspeed_engine.load_checkpoint(
checkpoint_path, load_optimizer_states=is_fitting, load_lr_scheduler_states=False
checkpoint_path,
load_optimizer_states=is_fitting,
load_lr_scheduler_states=False,
load_module_strict=self.lightning_module.strict_loading,
)
if client_state is None:
raise MisconfigurationException(
Expand Down
Loading