Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logsigmoid op #1520

Merged
merged 10 commits into from
Dec 14, 2024
Merged

add logsigmoid op #1520

merged 10 commits into from
Dec 14, 2024

Conversation

beverlylytle
Copy link
Collaborator

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Add support for the logsigmoid activation function.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

thunder/torch/__init__.py Outdated Show resolved Hide resolved
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

I made some suggestions for your review, @beverlylytle. I hope you find looking into implementation speed and memory use as interesting as I do!

thunder/torch/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad!

I filed #1555 for avoiding the creation of the extra CUDA tensor by adding a custom autograd formula for logsigmoid that would only apply when using the PyTorch executor

@beverlylytle beverlylytle merged commit 6c4e020 into main Dec 14, 2024
41 checks passed
@beverlylytle beverlylytle deleted the add_logsigmoid branch December 14, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants