-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logsigmoid op #1520
add logsigmoid op #1520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting!
I made some suggestions for your review, @beverlylytle. I hope you find looking into implementation speed and memory use as interesting as I do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rad!
I filed #1555 for avoiding the creation of the extra CUDA tensor by adding a custom autograd formula for logsigmoid that would only apply when using the PyTorch executor
Before submitting
What does this PR do?
Add support for the
logsigmoid
activation function.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃