clean up imports of jit_ext.py
#1588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
force-pushed
the
crpa/jit-ext-imports
branch
from
f50253f to
adf216f
Compare
Signed-off-by: Masaki Kozuki <[email protected]>
for more information, see https://pre-commit.ci
crcrpar
force-pushed
the
crpa/jit-ext-imports
branch
from
d3254d5 to
d4b35e7
Compare
t-vi
reviewed
Jan 6, 2025
| @@ -1671,7 +1634,7 @@ def is_variableified_tensorproxy(v: Variable | Proxy) -> Proxy: | |||
|
|
|||
| prim(*args) | |||
|
|
|||
| cache_info = thunder._get_cache_info() | |||
| cache_info = _get_cache_info() | |||
There was a problem hiding this comment.
What's the advantage here?
To my mind, the original version is clearer because you immediately see that it is a function from a different module (and which). I can see how the shorter way is important for things that get used a lot, but this seems distributing the information that this is a utility function from the thunder/__init__.py int two lines that are 300 lines apart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
some cleaning of jit_ext's imports