[WIP] Test out thunder.jit w/ NeMo models. #1694
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
reviewed
Jan 25, 2025
| @@ -445,7 +454,8 @@ def test_hf_for_nemo(model_id): | |||
| # fullgraph=True used to work with transformers 4.45.2, but it doesn't work | |||
| # with 4.46.2 because of re.findall usage in the loss function | |||
| fullgraph = False | |||
| compiled_model = thunderfx(model, fullgraph=fullgraph) | |||
| # compiled_model = thunderfx(model, fullgraph=fullgraph) | |||
| compiled_model = thunder.jit(model, fullgraph=fullgraph) | |||
There was a problem hiding this comment.
Wasn't this failing due to unsupported argument as I thought thunder.jit doesn't have fullgraph argument?
Or **compile_options takes keyword argument so there wouldn't be errors for unsupported args?
Suggested change
| compiled_model = thunder.jit(model, fullgraph=fullgraph) | |
| compiled_model = thunder.jit(model, fullgraph=fullgraph) |
There was a problem hiding this comment.
Nope. One can see the logs by clicking through the CI links below:
=========================== short test summary info ============================
FAILED thunder/tests/test_networks.py::test_hf_for_nemo[bigcode/starcoder2-7b] - AssertionError
FAILED thunder/tests/test_networks.py::test_hf_for_nemo[microsoft/Phi-3-mini-128k-instruct] - AssertionError: expected tensor with (48,), cuda:0, torch.float32, requires_grad=False, got (1,), cuda:0, torch.bfloat16, False
FAILED thunder/tests/test_networks.py::test_thunderfx_mistral_nemo_small - AssertionError
============ 3 failed, 29 passed, 172 warnings in 172.63s (0:02:52) ============
so I guess your theory is correct that we do not error out due to unsupported (kw)args.
I have a vague memory of us discussing doing that though; maybe it's just a warning?
There was a problem hiding this comment.
That is one of the things I dislike about the options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Demonstrates how to test thunder.jit with NeMo models.
PR review
This isn't meant to be merged or reviewed. If we actually want to do this, someone would want to extend the testing to test both
thunder.jitandthunder.dynamo.thunderfx, not remove the thunderfx testing (as done here).Did you have fun?
With this group, always :-)