Remove kwarg construction from FusionDefinitionWrapper.__call__ #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
mruberry
approved these changes
Mar 12, 2025
kiya00
reviewed
Mar 31, 2025
IvanYashchuk
commented
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces kwarg construction with a single attribute access on the
fdobject. This doesn't improve latency only simplifies the code of the call method.There are currently 7 attribute accesses in the FusionDefinitionWrapper.__call__ implementation. A few nanoseconds speed up for each of these accesses is achieved by using
__slots__/slots=True.cc @tfogal