Skip to content

fix: remove cmake pin and update flaky test to skipif #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: remove cmake pin and update flaky test to skipif #1919

wants to merge 4 commits into from
+7 −3

Conversation

k223kim
Copy link
Contributor

@k223kim k223kim commented Mar 31, 2025 •
edited by github-actions bot
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This is a follow up to the transfomers bump PR (#1911).

  • Remove cmake pin as PyTorch is buildable with cmake > 4.x
  • Add better reason to skip the flaky test

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@k223kim k223kim force-pushed the k223kim/chore-add-details-to-skip branch from 23132e8 to 15d8ff4 Compare March 31, 2025 15:40
@k223kim k223kim changed the title chore: remove cmake pin fix: remove cmake pin and update flaky test to skipif Mar 31, 2025
@k223kim k223kim marked this pull request as ready for review March 31, 2025 15:50
@crcrpar
Copy link
Collaborator

crcrpar commented Apr 22, 2025 •
edited
Loading

This looks nice but can we separate this PR into two? one of for cmake and the other for transformers?
As for the transformers test, how about adding parameterization of with and without apex for cross entropy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@aniketmaurya aniketmaurya aniketmaurya approved these changes

@ali-alshaar7 ali-alshaar7 ali-alshaar7 approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci dependencies docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k223kim @crcrpar @Borda @aniketmaurya @ali-alshaar7