Add tests for HFTransformers recipe with static cache#2179
Merged
Conversation
858d468 to
d255e79
Compare
Borda
reviewed
Jun 3, 2025
Borda
approved these changes
Jun 3, 2025
Collaborator
|
So on our CI it's more like 4 minutes is there any way to further reduce this? |
t-vi
reviewed
Jun 3, 2025
KaelanDt
commented
Jun 3, 2025
KaelanDt
commented
Jun 3, 2025
Collaborator
Author
in fact there is a smaller version of Qwen2.5, so I added that. Better now @t-vi |
161b347 to
d6f8751
Compare
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Partially fixes #2067 (backward to come in a subsequent PR) by adding a
generatetest with static cache on Qwen2.5 and Llama3.the two tests take 1:40 total to run on an L4.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃