-
Notifications
You must be signed in to change notification settings - Fork 98
bump bitsandbytes from 0.42.0 to 0.47.0.dev0 #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…under into bump-bitsnbytes
…/test.txt, clean up repo
@@ -53,6 +53,16 @@ jobs: | |||
run: | | |||
sudo apt-get install -y graphviz | |||
|
|||
- name: Build bitsandbytes 0.47.0.dev0 # 0.46.0 has a bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice to try in the PR, but I don't think we want to land dependency on compiled code... so if this pass, we would still wait util 0.47 is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, was not sure if we should do 0.47.0.dev0 and switch to 0.47.0 when it launches or just wait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add 0.46
and bump 0.47
when it is released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am guessing "they" is bitsandbytes-foundation? should i open an issue in bitsandbytes repo? how exactly do i ask them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for testing this PR, but if we consider releasing it later on, this won't be included as PyPI does not allow any dependency outside its registry, so the BnB would be missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, --force-reinstall
will reinstall dependencies of BnB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inquiry About bitsandbytes 0.47 Release Timeline and Potential Release Candidate
Description
Hello bitsandbytes team,
We have noticed that a critical fix we depend on has already been merged into the master branch (refer to [insert relevant PR or commit link if known]). We are eager to incorporate this fix into our development workflow and would like to inquire about the planned timeline for the next 0.47 release.
Additionally, we observed in the PyPI history that the team has previously released release candidates (RCs) for certain versions. Given the importance of this fix, would it be possible to consider releasing a release candidate for 0.47 soon? This would allow us to validate the changes early and continue our development with confidence.
Questions
- What is the planned timeline for the official 0.47 release?
- Is there a possibility of releasing a 0.47 release candidate in the near term to facilitate early validation?
- Are there any blockers or additional steps required before an RC or full release can be prepared?
Additional Context
- We are relying on the fix merged in [insert PR/commit details if available] for [briefly describe the use case or impact].
- Our team is prepared to test and provide feedback on an RC if one is made available.
Thank you for your time and for maintaining this valuable library! Please let us know if there’s any way we can assist in testing or validating the upcoming release.
Environment
- bitsandbytes version: [e.g., 0.46.0 or latest master]
- Python version: [e.g., 3.10]
- Platform: [e.g., Linux, CUDA 12.x]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't this this would land until there is proper 0.47.0
release
1b3f850
to
95e45d9
Compare
95e45d9
to
17b6399
Compare
Before submitting
What does this PR do?
Addresses #2128. Bumps to 0.47.0-dev0 because 0.46.0 (latest release) had a bug that has been patched. Let me know if there is anywhere else that needs updating.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃