Add PEFT benchmarking script in thunder/benchmarks#2254
Merged
Conversation
for more information, see https://pre-commit.ci
4 tasks
KaelanDt
reviewed
Jun 19, 2025
Collaborator
KaelanDt
left a comment
There was a problem hiding this comment.
Great add! Left some small comments
KaelanDt
approved these changes
Jun 27, 2025
t-vi
approved these changes
Jul 7, 2025
Collaborator
t-vi
left a comment
There was a problem hiding this comment.
Thank you @riccardofelluga @KaelanDt
At some point we might look at splitting out the various requirements here, but not now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR picks up and replaces #1978 with some tweaks. It introduces PEFT benchmarks for single gpu and multi-gpu with fsdp2 as deistributed strategy.
PR review
Can be tested by running:
Multi-GPU:
Side notes
I've extended the logging from the original PR and removed the prints. Now this uses the log levels to print more or less information depending on
--verboseflag.@crcrpar in the fsdp2 part I carried it over from the
benchmark_litgpt.pyfile, but I've commented out the litgpt specific layers. I've left it there for now but I am planning to remove them after the review, let me know if you think I should find the equivalent layers in transformers and adapt that code.cc. @wprazuch