Remove external logger dependency#2327
Merged
riccardofelluga merged 3 commits intomainfrom Jul 21, 2025
Merged
Conversation
crcrpar
approved these changes
Jul 14, 2025
Borda
approved these changes
Jul 15, 2025
Collaborator
Borda
left a comment
There was a problem hiding this comment.
I am fine with trimming dependencies, but could you pls share the motivation?
Collaborator
|
I personally would find it better to remove a benchmark specific dependency if it's not that difficult to remove it and the required code change isn't overwhelming |
Collaborator
Author
Yess so this came up in the PR that merged the benchmark script #2254 (review) and I've told @t-vi that I would try to move from this dep to the internal Thunder logger. However the logger is better reserved to Thunder internals and therefore I've just removed the |
t-vi
approved these changes
Jul 21, 2025
Collaborator
t-vi
left a comment
There was a problem hiding this comment.
Thank you @riccardofelluga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After discussing with @crcrpar we thought it's better to remove the dependency to loguru and not use #2275.
The log looks like:
cc @Borda