Skip to content

Add first draft for multi modal model training text & image #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Jun 13, 2024

Conversation

rakro101
Copy link
Contributor

@rakro101 rakro101 commented Jun 9, 2024

Before submitting

What does this PR do?

Add an example for multi modal model training.

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4cc7945). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #160   +/-   ##
=====================================
  Coverage        ?    77%           
=====================================
  Files           ?     30           
  Lines           ?   4151           
  Branches        ?      0           
=====================================
  Hits            ?   3206           
  Misses          ?    945           
  Partials        ?      0           

Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress :)

@rakro101
Copy link
Contributor Author

Did you read the contributor guideline, Pull Request section? this file not exists @tchaton

@rakro101 rakro101 marked this pull request as ready for review June 11, 2024 06:27
@rakro101 rakro101 requested a review from awaelchli as a code owner June 11, 2024 06:27
@rakro101 rakro101 requested a review from tchaton June 11, 2024 06:27
Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better

@rakro101
Copy link
Contributor Author

Few more comments. Also is there a way we can run this example (in some minimal version) inside our CI?

i added cl_run.py - does this fit for you?

@rakro101 rakro101 requested a review from justusschock June 11, 2024 13:50
@tchaton tchaton merged commit 0735dc3 into Lightning-AI:main Jun 13, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants