Skip to content

Fix: dataloader state dict indexerror #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

esivonxay-cognitiv
Copy link
Contributor

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This fixes the issue reported in #196.

Note: I had to change part of another unittest in this fix. I think the existing test was written expecting _num_samples_yielded_combined to be the combined total # of samples yielded by the CombinedStreamingDataset.

However, I believe the StreamingDataLoader._num_samples_yielded_combined field is a dictionary which maps the worker_id to a list containing the number of samples yielded from each dataset within a CombinedStreamingDataset.

Is my understanding of "combined" in _num_samples_yielded_combined correct?

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3be136b). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #198   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     33           
  Lines           ?   4488           
  Branches        ?      0           
=====================================
  Hits            ?   3492           
  Misses          ?    996           
  Partials        ?      0           

@tchaton tchaton merged commit e88fb52 into Lightning-AI:main Jun 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants