Fix: dataloader state dict indexerror #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
This fixes the issue reported in #196.
Note: I had to change part of another unittest in this fix. I think the existing test was written expecting
_num_samples_yielded_combined
to be the combined total # of samples yielded by theCombinedStreamingDataset
.However, I believe the
StreamingDataLoader._num_samples_yielded_combined
field is a dictionary which maps the worker_id to a list containing the number of samples yielded from each dataset within aCombinedStreamingDataset
.Is my understanding of "combined" in
_num_samples_yielded_combined
correct?